Refactor download assessment data function content#2
Open
GodzillaBogart4 wants to merge 18 commits intoStrongTownsLangley:mainfrom
Open
Conversation
Fix Assessed Value
Previous file had missing/outdated information for assessments, this has been updated with the latest GeoJSON from https://data-tol.opendata.arcgis.com/datasets/6f63c681511e4856836a7c9f988a0a6f_0/
… fallback to Geosource if not in Parcel File
…improve readability and create a class that changes to given urls to query urls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I am interested in contributing to this project. My pull request refactors a portion of the code for the sake of readability using the principles from the book "Clean Code" by Robert C. Martin. I went through all of the steps listed in your readme after I refactored the code in order to make sure that it stills runs normally. And luckily, everything is still normal.
I would also like to continue contributing to this project in the future. Please let me know if you have any questions.