Skip to content

Commit

Permalink
Try and address collaborators api issue
Browse files Browse the repository at this point in the history
Returned 404, I think you cannot create a var off of `router.route('...')` and
reuse it.
  • Loading branch information
Ilya Radchenko committed Sep 9, 2016
1 parent 8837d47 commit ed75a90
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions lib/routes/collaborators/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@ var models = require('../../models');
var utils = require('../../utils');
var api = require('./api');
var router = new express.Router();
var rootRoute = router.route('/');
var User = models.User;

rootRoute.all(
router.route('/').all(
auth.requireUserOr401,
middleware.project,
auth.requireProjectAdmin
Expand All @@ -28,7 +27,7 @@ rootRoute.all(
* @apiExample {curl} CURL Example:
* curl -X GET http://localhost/api/strider-cd/strider/collaborators
*/
rootRoute.get(function getCollab(req, res) {
router.route('/').get(function getCollab(req, res) {
var project = `${req.params.org}/${req.params.repo}`;

User.collaborators(project, 0, function (err, users) {
Expand Down Expand Up @@ -69,7 +68,7 @@ rootRoute.get(function getCollab(req, res) {
* @apiParam (RequestBody) {Number} access=0 Access level to grant to the
* new collaborator. This can be `0`, for read only access, or `2` for admin access.
*/
rootRoute.post(middleware.requireBody(['email']), function addCollab(req, res) {
router.route('/').post(middleware.requireBody(['email']), function addCollab(req, res) {
var project = `${req.params.org}/${req.params.repo}`;
var accessLevel = req.body.access || 0;
var email = req.body.email;
Expand Down Expand Up @@ -104,7 +103,7 @@ rootRoute.post(middleware.requireBody(['email']), function addCollab(req, res) {
*
* @apiParam (RequestBody) {String} email Email address to remove from the repo/project.
*/
rootRoute.delete(middleware.requireBody(['email']), function delCollab(req, res) {
router.route('/').delete(middleware.requireBody(['email']), function delCollab(req, res) {
var project = `${req.params.org}/${req.params.repo}`;
var email = req.body.email;

Expand Down

0 comments on commit ed75a90

Please sign in to comment.