Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Catalan filename for correct locale naming #667

Closed
wants to merge 1 commit into from

Conversation

pereorga
Copy link

"ca-ES" stands for Catalan as spoken in Spain. "CA" in "ca-CA" is the ISO country code for Canada.

@bogdan-the-great
Copy link

Is this the same situation as in #604?

@xeanhort
Copy link
Contributor

Yes it is. I'm not sure about the issues mentioned there (loosing the configuration in the devices) or if the best option is to duplicate them.

In fact, I think the best option is to remove the country codes whenever possible and keep only the first part.

@pereorga
Copy link
Author

@piotr-marendowski @xeanhort let me know if you want me to rebase this, or if you want me to switch to use ca.json.

@xeanhort
Copy link
Contributor

PR with the latest changes here. Once merged, @pereorga, you can proceed with the best approach to fix this

@pereorga
Copy link
Author

@xeanhort thanks. I don't think it makes sense to keep rebasing this PR. Instead, I've created #696 to track the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants