This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
WIP: Refactor OpenConnect VPN client instructions into user selectable client profiles #1409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streisand's current strategy of generating instructions for OpenConnect poses a number of usability issues when attempting to follow client specific instructions:
This PR attempts to address these issues by displaying per-client instructions where relevant, selectable via a drop down menu for each device that requires it.
The following platforms have been refactored:
In order to continue leveraging our current markdown templates and provide support for selectable instructions, the use of
<div>
elements were necessary; the originalmarkdown
only operates on<span>
level elements and caused rendering issues, thus needed to be replaced with a python implementation of markdown. While the final result does appear to be faithful, some quirks are apparent and warrants discussion.Screenshots:
Comments and feedback appreciated!