Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kalaallisut #3564

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Create kalaallisut #3564

wants to merge 1 commit into from

Conversation

IvaluBC
Copy link

@IvaluBC IvaluBC commented Dec 21, 2023

Adding Greenlandic constellation names

Description

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Adding Greenlandic constellation names
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
  • Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
  • Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures (see info.ini file)?
  • Did you remember to define license parameter in sky cultures (see info.ini file)?
  • Did you remember to define region parameter in sky culture (see info.ini file)?

This is an automatically generated QA checklist based on modified files.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your first pull request to Stellarium. If you have questions, please do not hesitate to contact us.

@gzotti
Copy link
Member

gzotti commented Dec 21, 2023

Did you intend to actually add files? This is still empty.

@gzotti
Copy link
Member

gzotti commented Mar 23, 2024

@IvaluBC ?

@UlloriaqPlanetarium
Copy link

UlloriaqPlanetarium commented Mar 26, 2024

So sorry for the late reply! I have gotten a new computer and cannot, at the moment, run the stellarium source files to see whether the constellations are added correctly. I have to get this running before I try to add the files again.
/ Ivalu

@gzotti
Copy link
Member

gzotti commented Sep 4, 2024

@IvaluBC any news?

@gzotti gzotti marked this pull request as draft October 10, 2024 20:10
@alex-w alex-w added the subsystem: skycultures The issue is related to skycultures of planetarium... label Oct 13, 2024
@alex-w alex-w added the purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
purpose: cultural astronomy Issues, pull requests and proposals with cultural astronomy purposes subsystem: skycultures The issue is related to skycultures of planetarium...
Development

Successfully merging this pull request may close these issues.

4 participants