Added new skyculture 'marathi'

[santoshasalunke]

This sky culture is prepared with Marathi names of modern constellations, planets and stars. Marathi names in Devnagari script are in "Native" list, whereas IAU names are in "Translated". Constellation names in Marathi were coined by Balshashtri Jambhekar (1812-46) and published in his magazine "Digdurshun" in year 1842. He translated these names from English to
Marathi.

Description

Added new Skyculture "marathi", it have constellations, stars and planet names in marathi language.
There is big community of marathi speaking amatuer astronomers who will find this skyculture useful.
No dependencies.

Fixes # (issue)

Screenshots (if appropriate):

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• This change requires a documentation update

How Has This Been Tested?

Tested on Windows 10 Laptop.
Instaalation done with coping files to directory = C:\Users<username>\stellarium\skycultures\marathi

Test Configuration:

• Operating system: Windows 10
• Graphics Card: Intel>

Checklist:

• My code follows the code style of this project.
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (header file)
• I have updated the respective chapter in the Stellarium User Guide
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

• Did you remember to update po/stellarium-skycultures/POFILES.in file respectively to changes in sky cultures?
• Did you remember to update skycultures/CMakeLists.txt and skycultures/YOUR-SKYCULTURE-FOLDER/CMakeLists.txt files respectively to changes in sky cultures?
• Did you remember to update util/skycultures/po4a.config file respectively to changes in sky cultures?
• Did you remember to define classification parameter in sky cultures (see info.ini file)?
• Did you remember to define license parameter in sky cultures (see info.ini file)?
• Did you remember to define region parameter in sky culture (see info.ini file)?

This is an automatically generated QA checklist based on modified files.

[Surendrajat]

Thanks for adding this. I don't see any need to add Hindi separately anymore.

Btw, could you check the old Indian skyculture added here? I was reviewing both side-by-side and found few discrepancies(in that one I guess, I'm no expert).

[gzotti]

Thank you for your interest. However I see numerous problems.

First, description.en.utf8 MUST be English only. Other languages need their own file, named description.<LANG>.utf8 as described in the User Guide, chapter 9.

star_names.fab: There are a handful of Marathi star names, the rest are standard names. These should be removed.

dso_names.fab: These are modern names from scientific and popular Western culture and most likely not original for Marathi culture.

The constellationship.fab is a copy from the modern(IAU) sky culture.

If there are no original figures, story, history (apart from source of translation), this looks indeed like only a translation into your language and should be treated as such. Transifex is the place to translate the default constellation names to your language. You can request any language supported by Transifex if necessary.

[santoshasalunke]

Trying to answer "gzotti"

Fist, description.en.utf8 MUST be English only. Other languages need their own file, named description..utf8 as described in the User Guide, chapter 9.

Created different file for marathi language = "description.mr.utf8"

star_names.fab: There are a handful of Marathi star names, the rest are standard names. These should be removed.

Yes, it is intended to be mix of both "standard names" + "marathi names".

dso_names.fab: These are modern names from scientific and popular Western culture and most likely not original for Marathi culture.

The constellationship.fab is a copy from the modern(IAU) sky culture.

If there are no original figures, story, history (apart from source of translation), this looks indeed like only a translation into your language and should be treated as such. Transifex is the place to translate the default constellation names to your language. You can request any language supported by Transifex if necessary.

Yes, this is a translation of modern skyculture done in 1842. I want to keep it as skyculture because marathi users shold be able to switch between marathi and modern names.

Transifex is good for interface of software, but right now only 2% is translated in marahti transifex and it will need mammoth effort to translate remaining and make it useful.

I think giving skyculture will be easier and quck way to allow users available marathi names without changing entire software interface.

[gzotti]

Sorry, but I disagree. This is a translation of "western" (default) names and figures, and not a genuine (re)creation of an independent development. To switch between Marathi and e.g. English, all you need to do is switching skyculture language. Whatever has not been translated to Marathi will show up in English.
The advantage of using translation is that if components of the modern (default) skyculture change (new star or DSO names, etc) they will be available without updating Marathi SC as well. And given that this proposed Marathi SC is just a translated version of "modern" with a few names in Marathi, the rest in English, this IMO is the way to do this. The annotation about the 1842 translation can be added to a paragraph in the translation of the default description text.

[santoshasalunke]

OK.

Lets hope this policy decision will be reversed in future.