Extracted all the colours to colour palette css #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefMa
force-pushed
the
master
branch
11 times, most recently
from
7c769b3
to
1907474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is in this PR?
In this Pull Request, I have extracted all the colours in the theme as variables in the
assets/fresh/partials/_colors.scssfile. I have also created aassets/fresh/partials/_colorpalette.scssfile to house the old definitions of the colours.Also,
assets/fresh/partials/_*.scssfiles got their colours redefined as the new variables.I also was annoyed that the main colour (orange) was called secondary, so I swapped the values of primary and secondary. I hope you don't mind.
Finally, I think I fixed a small HTML bug I found while working on the scss.
Why is this useful?
I wanted to customise the theme's colours fully. And I found the old definitions to be limiting. I know this does not address #89 fully as I don't know how to make the colours accessible from the config file, but this is the closest I can get to a proper customisation.
What can be done ideally?
If any of the maintainers or an interested contributor with Hugo experience exist, they can take the starting point I made and improve upon it, till it addresses #89 completely. If not, this can be merged directly, since I tried my best to stay faithful to the great design you made.