Node18 patch arique #2316
Open
Node18 patch arique #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arique1104
commented
Dec 1, 2023
lambda.js
Outdated
| @@ -1,5 +1,4 @@ | |||
| "use strict"; | |||
| const AWS = require("aws-sdk"); | |||
| "use strict";; | |||
There was a problem hiding this comment.
Interesting. I should remove that extra semi-colon that came on after the migration commands.
Arique1104
commented
Dec 1, 2023
| @@ -4,8 +4,8 @@ | |||
| "description": "Spoke", | |||
| "main": "src/server", | |||
| "engines": { | |||
| "node": ">=16.18.0", | |||
| "npm": "8.19.2" | |||
| "node": ">=20.0.0", | |||
There was a problem hiding this comment.
This was a critical lesson learned! Some of our features do have have support in version 21, and so choosing version20 is our main priority, but no higher!
Arique1104
commented
Dec 1, 2023
| @@ -3,7 +3,8 @@ import { unzipPayload } from "../../../workers/jobs"; | |||
| import { getConfig, hasConfig } from "../../../server/api/lib/config"; | |||
| import { gunzip } from "../../../lib"; | |||
|
|
|||
| import AWS from "aws-sdk"; | |||
| import { getSignedUrl } from "@aws-sdk/s3-request-presigner"; | |||
| import { PutObjectCommand, S3 } from "@aws-sdk/client-s3"; | |||
There was a problem hiding this comment.
Why wasn't something similar added to mobile-commons document up top?
Arique1104
commented
Dec 1, 2023
| @@ -1,5 +1,4 @@ | |||
| import request from "request"; | |||
| import aws from "aws-sdk"; | |||
There was a problem hiding this comment.
I've reviewed this document and see no aws method being used or replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes StateVoicesNational#3
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP
Checklist: