Skip to content

[BugFix] Fix array column cloning durign array comparison #61036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SHaaD94
Copy link
Contributor

@SHaaD94 SHaaD94 commented Jul 17, 2025

Why I'm doing:

What I'm doing:

Changing the way how column is cloned for comparison.
Currently in master we:

  • get the elements column of array and making it's empty copy
  • get all contents of datum (array)
  • add it to elements column
  • In the end instead of ArrayColumn we have Column<NullColumn>

Instead now I:

  • create an empty copy of array column
  • copy content of datum array into the new column

Fixes #61029

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

@SHaaD94 SHaaD94 requested a review from a team as a code owner July 17, 2025 10:17
@SHaaD94 SHaaD94 force-pushed the fix-column-copy-in-array-comparison branch from 0856390 to ba72e9f Compare July 17, 2025 10:23
@stdpain
Copy link
Contributor

stdpain commented Jul 17, 2025

Thanks for your feedback. I will add a new test case later.

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 0 / 2 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/sorting/compare_column.cpp 0 2 00.00% [160, 161]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CN crashes with assertion error during querying order by array with large limit
2 participants