Skip to content

[Enhancement] Force reuse for CTE with excessive nodes to avoid long optimizer time. #60983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Enhancement] Force reuse for CTE with excessive nodes to avoid long optimizer time. #60983

wants to merge 3 commits into from
+333 −128

Conversation

stephen-shelby
Copy link
Contributor

@stephen-shelby stephen-shelby commented Jul 16, 2025 •
edited
Loading

Why I'm doing:

Currently, when entering the optimizer from the relation transformer, CTE consumer nodes will attach the producer's plan tree underneath to facilitate predicate pushdown and limit pushdown. When the CTE producer's OptExpression and its child nodes are numerous, the optimizer will take a very long time.

CTE Producer contains 1.5W nodes with 4 consumers referencing it.

-----------------------------------------------------------------------------------------+
| Explain String                                                                          |
+-----------------------------------------------------------------------------------------+
|     0ms|-- Parser[1] 12ms                                                               |
|    12ms|-- Total[1] 36s688ms                                                            |
|    12ms|    -- Analyzer[1] 6ms                                                          |
|    12ms|        -- Lock[1] 0                                                            |
|    12ms|        -- AnalyzeDatabase[18] 0                                                |
|    12ms|        -- AnalyzeTemporaryTable[18] 0                                          |
|    12ms|        -- AnalyzeTable[18] 0                                                   |
|   798ms|    -- Transformer[1] 4s995ms                                                   |
|  5828ms|    -- Optimizer[1] 30s824ms                                                    |
|  5877ms|        -- MVPreprocess[1] 15ms                                                 |
|  5893ms|        -- MVTextRewrite[1] 0                                                   |
|  5893ms|        -- RuleBaseOptimize[1] 26s532ms                                         |
|  6191ms|            -- RewriteTreeTask[93] 19s206ms                                     |
|  6249ms|                -- GP_AGGREGATE_REWRITE[2582] 0                                 |
|  6314ms|                -- GP_SUBQUERY_REWRITE_TO_WINDOW[2580] 0                        |
|  6394ms|                -- TF_MV_TRANSPARENT_REWRITE_RULE[20714] 2ms                    |
|  6432ms|                -- GP_PUSH_DOWN_PREDICATE[573272] 34ms                          |
|  6432ms|                -- TF_PUSH_DOWN_PREDICATE_PROJECT[43812] 476ms                  |
|  6436ms|                -- TF_PUSH_DOWN_PREDICATE_JOIN[12919] 6s702ms                   |
|  6437ms|                -- TF_PUSH_DOWN_JOIN_CLAUSE[103500] 1s273ms                     |
|  6438ms|                -- TF_PUSH_DOWN_PREDICATE_CTE_CONSUME[6163] 10ms                |
|  6445ms|                -- TF_PUSH_DOWN_PREDICATE_SCAN[7806] 459ms                      |
| 15687ms|                -- TF_MERGE_TWO_PROJECT[45921] 388ms                            |
| 16352ms|                -- GP_ELIMINATE_OP_WITH_CONSTANT[23283] 1ms                     |
| 16422ms|                -- TF_CONVERT_TO_EQUAL_FOR_NULL_RULE[20700] 21ms                |
| 16525ms|                -- GP_PRUNE_COLUMNS[408940] 26ms                                |
| 16525ms|                -- TF_PRUNE_PROJECT_COLUMNS[208038] 742ms                       |
| 16529ms|                -- TF_PRUNE_UNION_COLUMNS[4] 0                                  |
| 16532ms|                -- TF_PRUNE_VALUES_COLUMNS[4] 0                                 |
| 16539ms|                -- TF_PRUNE_JOIN_COLUMNS[82804] 111ms                           |
| 16540ms|                -- TF_PRUNE_AGG_COLUMNS[10328] 20ms                             |
| 16541ms|                -- TF_PRUNE_CTE_CONSUME_COLUMNS[24784] 87ms                     |
| 16542ms|                -- TF_PRUNE_TOPN_COLUMNS[12] 0                                  |
| 16543ms|                -- TF_PRUNE_GROUP_BY_KEYS[10320] 6ms                            |
| 16548ms|                -- TF_PRUNE_OLAP_SCAN_COLUMNS[82856] 271ms                      |
| 17982ms|                -- GP_PRUNE_UKFK_JOIN[48656] 2ms                                |
| 18112ms|                -- TF_PUSH_DOWN_JOIN_ON_EXPRESSION_TO_CHILD_PROJECT[20700] 89ms |
| 19223ms|                -- GP_MERGE_LIMIT[301205] 15ms                                  |
| 19223ms|                -- TF_SPLIT_LIMIT[1] 0                                          |
| 19229ms|                -- TF_PUSH_DOWN_LIMIT[7] 0                                      |
| 19233ms|                -- TF_MERGE_LIMIT_WITH_LIMIT[6] 0                               |
| 19239ms|                -- TF_PUSH_DOWN_LIMIT_JOIN[2] 0                                 |
| 19244ms|                -- TF_MERGE_LIMIT_DIRECT[2] 0                                   |
| 19297ms|                -- TF_PUSH_DOWN_PROJECT_LIMIT[3] 0                              |
| 19711ms|                -- TF_PRUNE_SUBFIELD[20714] 61ms                                |
| 19923ms|                -- TF_PRUNE_PROJECT[121905] 9ms                                 |
| 19923ms|                -- GP_PRUNE_PROJECT[200793] 10ms                                |
| 20237ms|                -- TF_COLLECT_CTE_CONSUME[6196] 19ms                            |
| 20237ms|                -- GP_COLLECT_CTE[6208] 0                                       |
| 20258ms|                -- TF_COLLECT_CTE_PRODUCE[12] 0                                 |
| 20890ms|                -- TF_PUSH_CTE_PRODUCE[5] 2ms                                   |
| 21344ms|                -- TF_FORCE_CTE_REUSE[12] 34ms                                  |
| 21533ms|            -- RewriteDownTopTask[1] 146ms                                      |
| 21533ms|                -- TF_PREDICATE_PROPAGATE[20700] 107ms                          |
| 22107ms|                -- GP_PARTITION_PRUNE[200840] 11ms                              |
| 22107ms|                -- TF_PARTITION_PRUNE[41428] 61ms                               |
| 22107ms|                -- TF_DISTRIBUTION_PRUNE[41428] 163ms                           |
| 22803ms|                -- GP_PRUNE_EMPTY_OPERATOR[150645] 8ms                          |
| 23107ms|                -- TF_MERGE_PROJECT_WITH_CHILD[150585] 368ms                    |
| 23479ms|                -- TF_INNER_TO_SEMI[3] 0                                        |
| 24377ms|            -- JoinReorderLeftDeep[5294] 2s243ms                                |
| 24378ms|            -- JoinReorderDP[5294] 4ms                                          |
| 24378ms|            -- JoinReorderGreedy[5294] 2ms                                      |
| 30111ms|                -- GP_META_SCAN_REWRITE[2582] 0                                 |
| 31638ms|                -- TF_SPLIT_SCAN_OR[7740] 104ms                                 |
| 31851ms|                -- GP_VECTOR_REWRITE[3] 0                                       |
| 31862ms|                -- TF_PULL_UP_PREDICATE_SCAN[10320] 122ms                       |
| 32727ms|        -- CostBaseOptimize[1] 3s913ms                                          |
| 34957ms|            -- OptimizeGroupTask[203] 0                                         |
| 34957ms|            -- OptimizeExpressionTask[89201] 59ms                               |
| 34957ms|            -- ExploreGroupTask[120224] 14ms                                    |
| 34957ms|            -- DeriveStatsTask[89201] 1s335ms                                   |
| 34957ms|            -- ApplyRuleTask[59691] 184ms                                       |
| 34957ms|                -- JoinCommutativityWithoutInnerRule[36176] 13ms                |
| 34959ms|                -- SplitTwoPhaseAggRule[2582] 13ms                              |
| 35793ms|                -- SplitTopNRule[3] 0                                           |
| 36632ms|                -- CTEAnchorImplementationRule[12] 0                            |
| 36632ms|            -- EnforceAndCostTask[480] 6ms                                      |
| 36632ms|                -- CTEProduceImplementationRule[12] 0                           |
| 36632ms|                -- HashJoinImplementationRule[56] 0                             |
| 36632ms|                -- OlapScanImplementationRule[18] 0                             |
| 36633ms|                -- CTEConsumerReuseImplementationRule[24] 0                     |
| 36634ms|                -- HashAggImplementationRule[42] 0                              |
| 36639ms|                -- TopNImplementationRule[3] 0                                  |
| 36640ms|                -- UnionImplementationRule[1] 0                                 |
| 36640ms|                -- LimitImplementationRule[3] 0                                 |
| 36640ms|                -- NestLoopJoinImplementationRule[2] 0                          |
| 36640ms|                -- ValuesImplementationRule[1] 0                                |
| 36641ms|        -- PhysicalRewrite[1] 5ms                                               |
| 36647ms|        -- DynamicRewrite[1] 0                                                  |
| 36647ms|        -- PlanValidate[1] 5ms                                                  |
| 36647ms|            -- InputDependenciesChecker[1] 0                                    |
| 36647ms|            -- TypeChecker[1] 0                                                 |
| 36648ms|            -- CTEUniqueChecker[1] 0                                            |
| 36648ms|            -- ColumnReuseChecker[1] 0                                          |
| 36652ms|    -- ExecPlanBuild[1] 47ms                                                    |
| Tracer Cost: 393184us                                                                   |
+-----------------------------------------------------------------------------------------+
97 rows in set (36.72 sec)

What I'm doing:

When the producer nodes exceed the threshold, eliminate the consumer's child nodes and force reuse. After eliminating the consumer's child nodes, the optimizer can significantly reduce processing time.

+----------------------------------------------------------------------------------+
| Explain String                                                                   |
+----------------------------------------------------------------------------------+
|    0ms|-- Parser[1] 17ms                                                         |
|   17ms|-- Total[1] 985ms                                                         |
|   17ms|    -- Analyzer[1] 9ms                                                    |
|   17ms|        -- Lock[1] 0                                                      |
|   17ms|        -- AnalyzeDatabase[18] 0                                          |
|   17ms|        -- AnalyzeTemporaryTable[18] 0                                    |
|   17ms|        -- AnalyzeTable[18] 0                                             |
|  844ms|    -- Transformer[1] 13ms                                                |
|  858ms|    -- Optimizer[1] 70ms                                                  |
|  858ms|        -- MVPreprocess[1] 0                                              |
|  858ms|        -- MVTextRewrite[1] 0                                             |
|  858ms|        -- RuleBaseOptimize[1] 38ms                                       |
|  859ms|            -- RewriteTreeTask[93] 20ms                                   |
|  859ms|                -- GP_AGGREGATE_REWRITE[16] 0                             |
|  859ms|                -- GP_SUBQUERY_REWRITE_TO_WINDOW[14] 0                    |
|  860ms|                -- TF_MV_TRANSPARENT_REWRITE_RULE[19] 0                   |
|  860ms|                -- GP_PUSH_DOWN_PREDICATE[1223] 0                         |
|  860ms|                -- TF_PUSH_DOWN_PREDICATE_PROJECT[19] 0                   |
|  860ms|                -- TF_PUSH_DOWN_PREDICATE_JOIN[4] 0                       |
|  860ms|                -- TF_PUSH_DOWN_JOIN_CLAUSE[150] 2ms                      |
|  861ms|                -- TF_PUSH_DOWN_PREDICATE_CTE_CONSUME[19] 0               |
|  863ms|                -- TF_MERGE_TWO_PROJECT[104] 0                            |
|  863ms|                -- GP_ELIMINATE_OP_WITH_CONSTANT[47] 0                    |
|  864ms|                -- TF_CONVERT_TO_EQUAL_FOR_NULL_RULE[30] 0                |
|  864ms|                -- GP_PRUNE_COLUMNS[868] 0                                |
|  864ms|                -- TF_PRUNE_PROJECT_COLUMNS[390] 1ms                      |
|  864ms|                -- TF_PRUNE_UNION_COLUMNS[4] 0                            |
|  864ms|                -- TF_PRUNE_VALUES_COLUMNS[4] 0                           |
|  864ms|                -- TF_PRUNE_JOIN_COLUMNS[124] 0                           |
|  864ms|                -- TF_PRUNE_AGG_COLUMNS[64] 0                             |
|  864ms|                -- TF_PRUNE_TOPN_COLUMNS[8] 0                             |
|  864ms|                -- TF_PRUNE_GROUP_BY_KEYS[56] 0                           |
|  864ms|                -- TF_PRUNE_CTE_CONSUME_COLUMNS[96] 0                     |
|  864ms|                -- TF_PRUNE_OLAP_SCAN_COLUMNS[76] 0                       |
|  866ms|                -- GP_PRUNE_UKFK_JOIN[88] 0                               |
|  866ms|                -- TF_PUSH_DOWN_JOIN_ON_EXPRESSION_TO_CHILD_PROJECT[30] 0 |
|  868ms|                -- GP_MERGE_LIMIT[599] 0                                  |
|  868ms|                -- TF_SPLIT_LIMIT[1] 0                                    |
|  868ms|                -- TF_PUSH_DOWN_LIMIT[7] 0                                |
|  868ms|                -- TF_MERGE_LIMIT_WITH_LIMIT[6] 0                         |
|  868ms|                -- TF_PUSH_DOWN_LIMIT_JOIN[2] 0                           |
|  868ms|                -- TF_MERGE_LIMIT_DIRECT[2] 0                             |
|  869ms|                -- TF_PUSH_DOWN_PROJECT_LIMIT[3] 0                        |
|  870ms|                -- TF_PRUNE_SUBFIELD[19] 0                                |
|  870ms|                -- TF_PRUNE_PROJECT[169] 0                                |
|  870ms|                -- GP_PRUNE_PROJECT[385] 0                                |
|  871ms|                -- TF_COLLECT_CTE_CONSUME[24] 0                           |
|  871ms|                -- GP_COLLECT_CTE[35] 0                                   |
|  871ms|                -- TF_COLLECT_CTE_PRODUCE[11] 0                           |
|  872ms|                -- TF_PUSH_CTE_PRODUCE[5] 0                               |
|  874ms|                -- TF_FORCE_CTE_REUSE[11] 0                               |
|  874ms|            -- RewriteDownTopTask[1] 0                                    |
|  874ms|                -- TF_PREDICATE_PROPAGATE[30] 0                           |
|  875ms|                -- GP_PARTITION_PRUNE[426] 0                              |
|  875ms|                -- TF_PARTITION_PRUNE[38] 0                               |
|  875ms|                -- TF_DISTRIBUTION_PRUNE[38] 0                            |
|  876ms|                -- GP_PRUNE_EMPTY_OPERATOR[332] 0                         |
|  877ms|                -- TF_MERGE_PROJECT_WITH_CHILD[282] 0                     |
|  881ms|                -- TF_INNER_TO_SEMI[2] 0                                  |
|  885ms|            -- JoinReorderLeftDeep[1] 0                                   |
|  886ms|            -- JoinReorderDP[1] 0                                         |
|  886ms|            -- JoinReorderGreedy[1] 0                                     |
|  892ms|                -- GP_META_SCAN_REWRITE[16] 0                             |
|  896ms|                -- GP_VECTOR_REWRITE[2] 0                                 |
|  898ms|        -- CostBaseOptimize[1] 18ms                                       |
|  898ms|            -- OptimizeGroupTask[203] 0                                   |
|  898ms|            -- OptimizeExpressionTask[470] 1ms                            |
|  898ms|            -- ExploreGroupTask[544] 0                                    |
|  898ms|            -- DeriveStatsTask[470] 3ms                                   |
|  898ms|            -- ApplyRuleTask[595] 3ms                                     |
|  898ms|                -- JoinCommutativityRule[31] 0                            |
|  899ms|                -- SplitTwoPhaseAggRule[16] 0                             |
|  903ms|                -- SplitTopNRule[2] 0                                     |
|  903ms|                -- CTEAnchorImplementationRule[11] 0                      |
|  903ms|            -- EnforceAndCostTask[487] 9ms                                |
|  903ms|                -- CTEProduceImplementationRule[11] 0                     |
|  904ms|                -- HashJoinImplementationRule[60] 0                       |
|  904ms|                -- OlapScanImplementationRule[19] 0                       |
|  906ms|                -- CTEConsumerReuseImplementationRule[24] 0               |
|  906ms|                -- HashAggImplementationRule[48] 0                        |
|  914ms|                -- UnionImplementationRule[1] 0                           |
|  914ms|                -- LimitImplementationRule[3] 0                           |
|  914ms|                -- NestLoopJoinImplementationRule[2] 0                    |
|  914ms|                -- TopNImplementationRule[6] 0                            |
|  916ms|                -- ValuesImplementationRule[1] 0                          |
|  917ms|        -- PhysicalRewrite[1] 9ms                                         |
|  926ms|        -- DynamicRewrite[1] 0                                            |
|  927ms|        -- PlanValidate[1] 1ms                                            |
|  927ms|            -- InputDependenciesChecker[1] 0                              |
|  927ms|            -- TypeChecker[1] 0                                           |
|  928ms|            -- CTEUniqueChecker[1] 0                                      |
|  928ms|            -- ColumnReuseChecker[1] 0                                    |
|  928ms|    -- ExecPlanBuild[1] 74ms                                              |
| Tracer Cost: 1052us                                                              |
+----------------------------------------------------------------------------------+
94 rows in set (1.03 sec)
  1. When a CTE contains nested CTEs, disable the force reuse optimization for that CTE.
  2. Newly added session variable cbo_cte_force_reuse_node_count. default value is 2000. When the value is 0, disable the force reuse optimization

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

@stephen-shelby stephen-shelby requested a review from a team as a code owner July 16, 2025 09:02
@stephen-shelby stephen-shelby marked this pull request as draft July 16, 2025 09:02
@stephen-shelby stephen-shelby changed the title [Enhancement] Force reuse for CTE with excessive nodes to avoid long optimizer time. [UT] Force reuse for CTE with excessive nodes to avoid long optimizer time. Jul 16, 2025
@stephen-shelby stephen-shelby marked this pull request as ready for review July 16, 2025 09:31
@stephen-shelby stephen-shelby marked this pull request as draft July 16, 2025 09:32
@stephen-shelby stephen-shelby force-pushed the force_reuse_cte branch 2 times, most recently from ef2965a to 7e8d1c4 Compare July 20, 2025 15:57
@stephen-shelby stephen-shelby marked this pull request as ready for review July 20, 2025 15:58
@stephen-shelby stephen-shelby force-pushed the force_reuse_cte branch 3 times, most recently from 9d539d2 to 59cd215 Compare July 21, 2025 04:22
Seaven
Seaven previously approved these changes Jul 21, 2025
View reviewed changes
@stephen-shelby
fix failed ut
b20ca0b 
Signed-off-by: stephen <[email protected]>
@stephen-shelby
fix style
c5820b7 
Signed-off-by: stephen <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
49 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 51 / 51 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/transformer/RelationTransformer.java 30 30 100.00% []
🔵 com/starrocks/qe/SessionVariable.java 4 4 100.00% []
🔵 com/starrocks/sql/optimizer/Utils.java 5 5 100.00% []
🔵 com/starrocks/sql/optimizer/transformer/CTETransformerContext.java 4 4 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/PushDownPredicateCTEConsumeRule.java 7 7 100.00% []
🔵 com/starrocks/sql/optimizer/CTEUtils.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby changed the title [UT] Force reuse for CTE with excessive nodes to avoid long optimizer time. [Enhancement] Force reuse for CTE with excessive nodes to avoid long optimizer time. Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@Seaven Seaven Seaven approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@stephen-shelby stephen-shelby

Labels
3.3 3.4 3.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephen-shelby @Seaven