Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix array contains reuse null column #56810

Merged
merged 3 commits into from
Mar 12, 2025
Merged

[BugFix] Fix array contains reuse null column #56810

merged 3 commits into from
Mar 12, 2025
+65 −4

Conversation

before-Sunrise
Copy link
Contributor

Why I'm doing:

array_contains/array_length may reuse input nullable column's null column, but it's not safe.
like 'select nullable_array_col, array_contains(nullable_array_col) order by xxx", two output column will reuse same null column

What I'm doing:

fix https://github.com/StarRocks/StarRocksTest/issues/9367

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@before-Sunrise before-Sunrise requested a review from a team as a code owner March 11, 2025 08:32
@before-Sunrise
fix
c416cd2 
Signed-off-by: before-Sunrise <[email protected]>
@before-Sunrise
add test
b495cbe 
Signed-off-by: before-Sunrise <[email protected]>
@before-Sunrise
add test
c8d56c9 
Signed-off-by: before-Sunrise <[email protected]>
@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exprs/array_functions.tpp 1 1 100.00% []
🔵 be/src/exprs/array_functions.cpp 2 2 100.00% []

@silverbullet233 silverbullet233 enabled auto-merge (squash) March 12, 2025 05:34
@silverbullet233 silverbullet233 merged commit 7b5e9d6 into StarRocks:main Mar 12, 2025
55 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Mar 12, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Mar 12, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 12, 2025
@before-Sunrise @mergify
[BugFix] Fix array contains reuse null column (#56810)
9d6fdca 
Signed-off-by: before-Sunrise <[email protected]>
(cherry picked from commit 7b5e9d6)

# Conflicts:
#	be/src/exprs/array_functions.cpp
#	be/src/exprs/array_functions.tpp
#	test/sql/test_array_fn/R/test_array_contains
#	test/sql/test_array_fn/T/test_array_contains
@mergify mergify bot mentioned this pull request Mar 12, 2025
Closed
18 tasks
mergify bot pushed a commit that referenced this pull request Mar 12, 2025
@before-Sunrise @mergify
[BugFix] Fix array contains reuse null column (#56810)
3aa91ee 
Signed-off-by: before-Sunrise <[email protected]>
(cherry picked from commit 7b5e9d6)

# Conflicts:
#	be/src/exprs/array_functions.cpp
#	be/src/exprs/array_functions.tpp
#	test/sql/test_array_fn/R/test_array_contains
#	test/sql/test_array_fn/T/test_array_contains
@mergify mergify bot mentioned this pull request Mar 12, 2025
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satanson satanson satanson approved these changes

@silverbullet233 silverbullet233 silverbullet233 approved these changes

@LiShuMing LiShuMing LiShuMing approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@before-Sunrise before-Sunrise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@before-Sunrise @satanson @silverbullet233 @LiShuMing @kangkaisen