Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add storage-related profiles for load #45560

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

banmoy
Copy link
Contributor

@banmoy banmoy commented May 13, 2024

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@banmoy banmoy requested review from a team as code owners May 13, 2024 13:39
@banmoy banmoy marked this pull request as draft May 13, 2024 13:39
@mergify mergify bot assigned banmoy May 13, 2024
@@ -331,6 +331,16 @@ Status LoadChannel::_deserialize_chunk(const ChunkPB& pchunk, Chunk& chunk, fast
return Status::OK();
}

std::vector<int64_t> LoadChannel::_get_index_ids() {
std::vector<int64_t> index_ids;
std::lock_guard l(_lock);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How often is this fiction called? Will this impact the performance of concurrent ingestions

@banmoy banmoy force-pushed the storage_metric branch 2 times, most recently from 5d16753 to 653c8af Compare May 16, 2024 03:44
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Signed-off-by: PengFei Li <[email protected]>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 36 / 86 (41.86%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 src/exec/tablet_sink_index_channel.cpp 0 1 00.00% [780]
🔵 src/storage/delta_writer.h 0 6 00.00% [114, 120, 122, 124, 129, 132]
🔵 src/storage/segment_replicate_executor.cpp 0 9 00.00% [36, 48, 49, 50, 51, 54, 60, 249, 250]
🔵 src/storage/async_delta_writer.cpp 0 1 00.00% [91]
🔵 src/storage/segment_replicate_executor.h 0 1 00.00% [82]
🔵 src/runtime/local_tablets_channel.cpp 0 8 00.00% [71, 74, 77, 78, 79, 80, 81, 149]
🔵 src/storage/segment_flush_executor.cpp 0 8 00.00% [46, 47, 67, 69, 75, 76, 77, 78]
🔵 src/exec/tablet_sink.cpp 0 1 00.00% [194]
🔵 src/storage/delta_writer.cpp 5 13 38.46% [417, 497, 498, 499, 506, 512, 625, 626]
🔵 src/runtime/load_channel.cpp 4 10 40.00% [170, 171, 173, 175, 176, 177]
🔵 src/storage/memtable_flush_executor.cpp 6 7 85.71% [90]
🔵 src/storage/memtable.cpp 15 15 100.00% []
🔵 src/runtime/lake_tablets_channel.cpp 1 1 100.00% []
🔵 src/storage/memtable.h 5 5 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants