Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix duplicated error rows in load tracking log #45500

Merged
merged 2 commits into from May 16, 2024

Conversation

wyb
Copy link
Contributor

@wyb wyb commented May 11, 2024

Why I'm doing:

CREATE TABLE `t3` (
  `k1` bigint NOT NULL,
  `k2` bigint NOT NULL,
  `k3` bigint NOT NULL
)

insert into t3 values (null, null, null);

mysql> select tracking_log from information_schema.load_tracking_logs where job_id=284223;
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tracking_log                                                                                                                                                                                                 |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Error: NULL value in non-nullable column 'k1'. Row: [NULL, NULL, NULL]
Error: NULL value in non-nullable column 'k2'. Row: [0, NULL, NULL]
Error: NULL value in non-nullable column 'k3'. Row: [0, 0, NULL]
 |
+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.05 sec)

there are 3 rows in tracking logs and the last 2 rows are wrong.

What I'm doing:

mysql> select tracking_log from information_schema.load_tracking_logs where job_id=284327;
+-------------------------------------------------------------------------+
| tracking_log                                                            |
+-------------------------------------------------------------------------+
| Error: NULL value in non-nullable column 'k1'. Row: [NULL, NULL, NULL]
 |
+-------------------------------------------------------------------------+
1 row in set (0.02 sec)

only record the first invalid column k1 for the inserted row.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@wyb wyb requested a review from a team as a code owner May 11, 2024 11:05
@mergify mergify bot assigned wyb May 11, 2024
Signed-off-by: wyb <[email protected]>
Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/tablet_sink.cpp 1 1 100.00% []

@wyb wyb requested a review from meegoo May 16, 2024 03:08
@meegoo meegoo merged commit 1c48ef8 into StarRocks:main May 16, 2024
44 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 16, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label May 16, 2024
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label May 16, 2024
Copy link
Contributor

mergify bot commented May 16, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 16, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented May 16, 2024

backport branch-3.1

✅ Backports have been created

node pushed a commit to vivo/starrocks that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants