Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Report correct errors when there is no alive workers #45499

Merged
merged 1 commit into from May 20, 2024

Conversation

yandongxiao
Copy link
Contributor

Why I'm doing:

Report correct errors when there is no alive workers.

[sr@iZ8vbbr5n5arc0z8b22vabZ be]$ ./bin/stop_be.sh

mysql> create table t3(a int);
ERROR 1064 (HY000): Unexpected exception: Failed to get primary backend. shard id: 10117

mysql> select * from t12;
ERROR 1064 (HY000): Backend node not found. Check if any backend node is down.backend: [172.26.80.30 alive: false inBlacklist: false]

mysql> create table t9(a int);
ERROR 1064 (HY000): Unexpected exception: Failed to create shards. error: INVALID_ARGUMENT:shard info can not be empty.

When a warehouse has no alive workers, SR will report errors, but not quit correct.

What I'm doing:

In the logic of "create table" and "DefaultSharedDataWorkerProvider," check for the existence of an "alive worker."

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@yandongxiao yandongxiao requested a review from a team as a code owner May 11, 2024 10:06
@github-actions github-actions bot added the 3.3 label May 11, 2024
@yandongxiao yandongxiao force-pushed the bugfix/jira-sr-19141-2 branch 6 times, most recently from 9f87a6b to 3043913 Compare May 14, 2024 08:23
@yandongxiao yandongxiao requested a review from a team as a code owner May 14, 2024 08:23
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 43 / 58 (74.14%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/planner/OlapScanNode.java 2 4 50.00% [531, 532]
🔵 com/starrocks/server/LocalMetastore.java 3 5 60.00% [2502, 2503]
🔵 com/starrocks/lake/qe/scheduler/DefaultSharedDataWorkerProvider.java 5 7 71.43% [84, 85]
🔵 com/starrocks/server/WarehouseManager.java 29 38 76.32% [118, 121, 133, 194, 263, 279, 280, 285, 286]
🔵 com/starrocks/alter/LakeTableAlterJobV2Builder.java 1 1 100.00% []
🔵 com/starrocks/lake/LakeTableHelper.java 1 1 100.00% []
🔵 com/starrocks/lake/StarMgrMetaSyncer.java 2 2 100.00% []

@kevincai
Copy link
Contributor

DO remember to change the warehouse error message in separate patch.

@kevincai kevincai enabled auto-merge (squash) May 20, 2024 02:19
@wanpengfei-git wanpengfei-git merged commit caf34ac into StarRocks:main May 20, 2024
47 of 49 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 20, 2024
Copy link
Contributor

mergify bot commented May 20, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 20, 2024
wanpengfei-git pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants