-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable web buttons in forms after onClick #977
Conversation
@ParthS007 Thanks for the PR. Can you add a CHANGELOG entry, and maybe a GIF showing the changes before/after? |
Sorry - accidentally hit the close button... |
How long is the re-run disabled for? So if it's a long running workflow for instance, when does the button get re-enabled? |
Note. We are currently in code review, so we will need to save merging this until after 3.7 is released. I would like to see some tests with some long-running actions, as couldn't really tell from video when the button is getting re-enabled. |
Hello @amanda11, thanks for your comments.
I am starting to go through the code, I am not familiar with functionalities yet. Please let me know what should be the ideal time for the button being disabled. For now, The I can add tests for testing the disabled. |
@amanda11 From my understanding, the login button is disabled till a response is received (if success, it redirects anyway, if failed, it re-enables the button). For the action re-run form, I guess the button is disabled after the execution is launched, and since that component disappears, it should be okay (any new instance of re-run action should start with button not disabled). The idea is to prevent sending multiple requests by double clicking on the button. The buttons that lead to a redirection response, should be disabled on click (and need not be enabled manually?) |
@ParthS007 This looks great, I had a play with it, and it all looks great. Thanks for the contribution. I went through our manual regression, and all looked good as well. Could you do an update so that it picks up the master branch changes, this should build it as a 3.8 artifiact, and I can give it another quick spin, and then I'll be happy to merge. |
@amanda11 Thanks for your time for reviewing. I rebased the PR, please let me know if I need to add anything else. 👍 |
@ParthS007 If you get a chance, could you sign the contributor agreement and then I can merge. Thanks so much for the change. |
@amanda11 Signed. Thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the contribution.
@ParthS007 Many thanks for the PRs, that's all merged and will be available in StackStorm 3.8. |
ref #975
Add disable functionality on Submit the rerun and Login component
Now the user will not be able to send multiple request to
Connect(Login)
before receiving the response from server by adding thedisabled
ininput
.Before Rerun
Before.RERUN.mov
After_RERUN.mov