Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable web buttons on forms after clicks on request send #975

Open
rush-skills opened this issue Apr 25, 2022 · 4 comments · Fixed by #977
Open

Disable web buttons on forms after clicks on request send #975

rush-skills opened this issue Apr 25, 2022 · 4 comments · Fixed by #977
Assignees

Comments

@rush-skills
Copy link
Member

Some buttons (eg Login, Run Action) in the current st2web allow for clicking them again sending duplicate requests which might not be desired. If the response time is high, this also leads to a bad UX.

A good way to handle it would be to handle the button click, disable the button, and show a loader/status bar/alert/text somewhere instead. Does require reviewing all buttons to properly assign them error and other help/status texts.

A simpler quick fix should be to just disable (all?) buttons that lead to synchronous responses (page change) while the response is pending.

@arm4b
Copy link
Member

arm4b commented Apr 25, 2022

+1 good idea

@ParthS007
Copy link
Contributor

ParthS007 commented May 5, 2022

I want to work on it. @rush-skills

@amanda11
Copy link
Contributor

amanda11 commented May 5, 2022

How long is the re-run disabled for? So if it's a long running workflow for instance, when does the button get re-enabled?

@rush-skills
Copy link
Member Author

#977 fixes this for "Login" button on the homepage and "Re-run" button for action rerun. However, the "Run" button in actions page still has the same behavior and can be improved.

@rush-skills rush-skills linked a pull request May 12, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants