-
-
Notifications
You must be signed in to change notification settings - Fork 767
Update pants lockfiles. #6350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update pants lockfiles. #6350
Conversation
8770527
to
67af508
Compare
Do you have the lock file diff still? It gets printed after lock file generation. The diff view makes it much easier to see what changed. Reviewing the actual lock file changes is a lot. Also, I like to use that diff to update the version pins in the legacy requirements files. |
I don't have it, but it's nothing to re-run the generate process against master again. Would you like it as an attachment here? I can also backport the locking to the requirement files if you want that. |
Yes please. I try to put it in the diff in the commit message and in the PR description (in a Dealing with this is cumbersome. Maybe (in a different PR) we could add a GHA workflow that:
|
67af508
to
0cd8882
Compare
I pushed the generated lock files as well as the updates requirements.txt files. Here's the pants output:
|
I think someone from the community pointed out bitnami doing something with their images, so the CI errors might be related to that.
|
No description provided.