Skip to content

Conversation

jk464
Copy link
Contributor

@jk464 jk464 commented Jun 21, 2023

Enhances install_pack.py so that you can pass an optional flag to it (--get-dependencies) that will for a given pack when it is installed will also install any other packs the parent pack depdends on it.

Useful when using https://github.com/StackStorm/st2packs-dockerfiles/ to build a st2packs image, the user only has to provide the list of packs they want, without having to determine if they have any further packs as depdencies.

@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines. Good size to review. label Jun 21, 2023
@guzzijones
Copy link
Contributor

needs a changelog entry

@jk464 jk464 force-pushed the feature/pack_download branch from 3a547d6 to edcaec2 Compare August 15, 2023 14:31
@jk464
Copy link
Contributor Author

jk464 commented Aug 15, 2023

@guzzijones I've added a Changelog entry now

Copy link
Contributor

@guzzijones guzzijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple small adjustments. Thanks for your contribution.

@jk464 jk464 force-pushed the feature/pack_download branch from 271f8d3 to c52e8f4 Compare August 23, 2023 11:13
@pull-request-size pull-request-size bot added size/L PR that changes 100-499 lines. Requires some effort to review. and removed size/M PR that changes 30-99 lines. Good size to review. labels Aug 23, 2023
Copy link
Contributor

@guzzijones guzzijones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now

@jk464 jk464 force-pushed the feature/pack_download branch from c52e8f4 to 2bee3c5 Compare May 25, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature size/L PR that changes 100-499 lines. Requires some effort to review.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants