Drop six #271
Merged
Drop six #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 677afbe)
cognifloyd
reviewed
Feb 24, 2025
Comment on lines
-486
to
+488
| constants.TASK_STATE_ROUTE_FORMAT % (entry["id"], str(entry["route"])) | ||
| if entry["route"] > 0 | ||
| else entry["id"] | ||
| ( | ||
| constants.TASK_STATE_ROUTE_FORMAT % (entry["id"], str(entry["route"])) | ||
| if entry["route"] > 0 | ||
| else entry["id"] | ||
| ) |
There was a problem hiding this comment.
I don't see changes due to six here. Was this change (and some below) caused by black?
There was a problem hiding this comment.
Yes, I ran black after making code changes so I didn't hit linting errors. I should have made it two separate commits.
|
Do you want the date ranges restored to the original commit date? |
|
I think 2021 is the first date because that's when it was donated to the Linux Foundation. Adding the copyright line in the files where it is missing makes sense. For the rest, please remove the |
cognifloyd
reviewed
Feb 24, 2025
| @@ -1,3 +1,4 @@ | |||
| # Copyright 2020 The StackStorm Authors. | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2020 The StackStorm Authors. | |
| # Copyright 2021 The StackStorm Authors. |
orquesta/utils/jsonify.py
Outdated
| @@ -1,3 +1,4 @@ | |||
| # Copyright 2020-2025 The StackStorm Authors. | |||
There was a problem hiding this comment.
Suggested change
| # Copyright 2020-2025 The StackStorm Authors. | |
| # Copyright 2021 The StackStorm Authors. |
cognifloyd
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.