Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deprecated u2004 to u2204 image for github actions #26

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

nzlosh
Copy link
Contributor

@nzlosh nzlosh commented Feb 12, 2025

No description provided.

@nzlosh nzlosh requested a review from cognifloyd as a code owner February 12, 2025 17:59
@cognifloyd
Copy link
Member

Hmm. Maybe we need to comment out or delete the step that injects monkey patching in the nosetest binary.

- name: Update virtualenv activate script
# This works around an infinite recursion error with newer requests+ssl+eventlet.
# eventlet monkey_patch as early as possible (has to be in activate as nosetests gets reinstalled during test phase)
# See: https://github.com/StackStorm-Exchange/stackstorm-vault/pull/23
run: |
echo "grep -q monkey_patch ${VIRTUALENV_DIR}/bin/nosetests || sed -i -e '/^import re$/i from st2common.util.monkey_patch import monkey_patch\nmonkey_patch()\n' ${VIRTUALENV_DIR}/bin/nosetests" >> ${VIRTUALENV_DIR}/bin/activate
echo "grep -q pyopenssl\\.inject ${VIRTUALENV_DIR}/bin/nosetests || sed -i -e '/^import re$/i from urllib3.contrib import pyopenssl\npyopenssl.inject_into_urllib3()\n' ${VIRTUALENV_DIR}/bin/nosetests" >> ${VIRTUALENV_DIR}/bin/activate

Copy link
Member

@cognifloyd cognifloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. I don't think your matrix change worked

@cognifloyd cognifloyd merged commit 92af8db into StackStorm-Exchange:master Feb 13, 2025
5 checks passed
@nzlosh
Copy link
Contributor Author

nzlosh commented Feb 13, 2025

Thanks for the assist, I'm still grinding away on st2 GHA.

@nzlosh nzlosh deleted the github_u2204 branch February 13, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants