Merge pull request #25 from bertyah/master

Fix oneshot parameters to actually work

CHANGES.md

@@ -1,5 +1,10 @@
 # Change Log
 
+## 2.3.0
+
+- Refactor params for Oneshot search
+- Change ResultReader to JSONResultReader to fix the ResultsReader deprecated function.
+
 ## 2.2.0
 
 - Add `count` parameter to Oneshot search

actions/search.py

@@ -23,7 +23,7 @@ def __init__(self, config):
         else:
             raise ValueError("No Splunk configuration details found")
 
-    def run(self, instance, query, count):
+    def run(self, instance, query, count, offset):
         """stackstorm run method"""
         # Find config details
         if instance:
@@ -52,8 +52,8 @@ def run(self, instance, query, count):
                 "Failed to connect to Splunk Instance {} with error {}".format(splunk_config, err)
             )
 
-        result = self.service.jobs.oneshot(query, params={"output_mode": "json", "count": count})
-        reader = results.ResultsReader(result)
+        result = self.service.jobs.oneshot(query, count=count, offset=offset, output_mode='json')
+        reader = results.JSONResultsReader(result)
         search_results = []
 
         for item in reader:

actions/search.yaml

@@ -20,3 +20,9 @@ parameters:
     required: true
     position: 2
     default: 100
+  offset:
+    type: integer
+    description: "A number that specifies the index of the first entity to return"
+    required: true
+    position: 3
+    default: 0

pack.yaml

@@ -6,7 +6,7 @@ keywords:
   - splunk
   - monitoring
   - alerting
-version: 2.2.0
+version: 2.3.0
 author : StackStorm, Inc.
 email : [email protected]
 python_versions: