Update kafka-python to 2.0.2 to add support for python 3.8 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekharsr
force-pushed
the
master
branch
6 times, most recently
from
8f32f6d to
02c91a4
Compare
cognifloyd
reviewed
Dec 20, 2023
cognifloyd
requested changes
Dec 20, 2023
cognifloyd
changed the title
Addresses PR feedback (produce action should return a dict).
cognifloyd
reviewed
Jan 5, 2024
actions/produce.py
Outdated
Comment on lines
45
to
48
| try: | ||
| assert topic in consumer.topics() | ||
| except AssertionError as exc: | ||
| raise AssertionError(f"{topic} does not exist.") from exc |
There was a problem hiding this comment.
This is not a direct replacement for ensure_topic_exists() because: if the broker is configured to create topics automatically, then that will no longer happen here. Maybe this should actually just be a major version bump.
Also, apparently we have to update the sensors too.
This is a major version bump as topics will no longer be auto-created by the sensors or by the produce action even if the Kafka server is configured to auto-create the topics and partitions. That's a side-effect of updating a couple of major versions of the kafka-python dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
Closes #18