Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding medaka version 1.11.2 #799

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

erinyoung
Copy link
Contributor

Instead of using the older Dockerfiles for medaka, I copied the artic version 1.24-1.11.1 Dockerfile and just removed all the artic lines.

The prior medaka Dockerfile is for version 1.2.0, which was three years ago. This means that I needed to create an app and test stage in the Dockerfile and a README.md for 1.11.1. For the test, I downloaded an assembled CRPA genome with its corresponding nanopore reads.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number (i.e. spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@erinyoung
Copy link
Contributor Author

Closes #734

@erinyoung erinyoung changed the title adding medaka version 1.11.1 adding medaka version 1.11.2 Dec 1, 2023
@erinyoung
Copy link
Contributor Author

Medaka 1.11.2 came out, so I've updated the version number.

I did attempt to use the nvidia/cuda:11.2.2-cudnn8-runtime-ubuntu20.04 base (focal) like nanopore does for their version of medaka, but I kept running into issues with git lfs and pyapboa.

@kevinlibuit kevinlibuit self-requested a review December 14, 2023 19:34
@erinyoung erinyoung marked this pull request as draft January 8, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant