-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue: #79 Heart attack prediction model #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @jain-anshika! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rejecting it.
First start with Dataset exploration and EDA. Write your conclusions.
Later parts will be further issues. Don't just jump straight into prediction code.
Have a look at other issues and merged PRs.
@SrijanShovit Hey I added more comments and conclusion please check if it is okay now!! Thank you for giving me a chance to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the classification part for now; I will tell how to do that in next issues and assign you.
Do you mean I should only keep it till conclusions of EDA? |
yes, you might see for other projects also. I find it good for small steps as separate issues rather than entire project as one issue. This would help in learning and points both. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
So you see you don't have great accuracy. There can be some reasons. As we proceed with steps each with 1 issue, we can have better ideas which aspect to it to take accuracy till 98% or above. |
Issue: #79
Heart attack prediction model
The test accuracy score of Logistric Regression is 0.9016393442622951
The test accuracy score of SVM after hyper-parameter tuning is 0.9016393442622951
The test accuracy score of Gradient Boosting Classifier is 0.8688524590163934
The test accuracy score of Random Forest is 0.7868852459016393
The test accuracy score of Decision Tree is 0.7868852459016393