Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: #79 Heart attack prediction model #85

Merged
merged 3 commits into from
May 19, 2024

Conversation

jain-anshika
Copy link
Contributor

Issue: #79

Heart attack prediction model

The test accuracy score of Logistric Regression is 0.9016393442622951
The test accuracy score of SVM after hyper-parameter tuning is 0.9016393442622951
The test accuracy score of Gradient Boosting Classifier is 0.8688524590163934
The test accuracy score of Random Forest is 0.7868852459016393
The test accuracy score of Decision Tree is 0.7868852459016393

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @jain-anshika! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Owner

@SrijanShovit SrijanShovit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejecting it.
First start with Dataset exploration and EDA. Write your conclusions.
Later parts will be further issues. Don't just jump straight into prediction code.
Have a look at other issues and merged PRs.

@jain-anshika
Copy link
Contributor Author

@SrijanShovit Hey I added more comments and conclusion please check if it is okay now!!
Please tell me if there are any other changes needed.

Thank you for giving me a chance to work.

@jain-anshika jain-anshika requested a review from SrijanShovit May 17, 2024 16:09
Copy link
Owner

@SrijanShovit SrijanShovit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the classification part for now; I will tell how to do that in next issues and assign you.

@jain-anshika
Copy link
Contributor Author

Do you mean I should only keep it till conclusions of EDA?

@SrijanShovit
Copy link
Owner

Do you mean I should only keep it till conclusions of EDA?

yes, you might see for other projects also. I find it good for small steps as separate issues rather than entire project as one issue. This would help in learning and points both.

@SrijanShovit
Copy link
Owner

SrijanShovit commented May 19, 2024

Do you mean I should only keep it till conclusions of EDA?

yes, you might see for other projects also. I find it good for small steps as separate issues rather than entire project as one issue. This would help in learning and points both.

Copy link
Owner

@SrijanShovit SrijanShovit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@SrijanShovit
Copy link
Owner

Issue: #79

Heart attack prediction model

The test accuracy score of Logistric Regression is 0.9016393442622951 The test accuracy score of SVM after hyper-parameter tuning is 0.9016393442622951 The test accuracy score of Gradient Boosting Classifier is 0.8688524590163934 The test accuracy score of Random Forest is 0.7868852459016393 The test accuracy score of Decision Tree is 0.7868852459016393

So you see you don't have great accuracy. There can be some reasons. As we proceed with steps each with 1 issue, we can have better ideas which aspect to it to take accuracy till 98% or above.

@SrijanShovit SrijanShovit merged commit 97a28cf into SrijanShovit:main May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants