Remove bad supports() in key impl #4184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrHell228
force-pushed
the
api-12-key-fixes
branch
from
080e39c to
873584c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These
supportsmake no sense because these keys reflect components that can be applied to any stack.For firework data the only remaining limitation is that FIREWORK_STAR assumed to be the only item that can have
FIREWORK_EXPLOSIONcomponent. For other stacksKeys.FIREWORK_EFFECTSsets regular firework component (and will do the same whenever firework star component gets it's own key).