Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite attack and damage events #4138

Open
wants to merge 5 commits into
base: api-14
Choose a base branch
from
Open

Conversation

Yeregorix
Copy link
Member

@Yeregorix Yeregorix commented Oct 20, 2024

Sponge | SpongeAPI

This implementation is still a nightmare due to the insane amount of mixin injections but at least this nightmare is correct whereas the previous nightmare was broken.

@Yeregorix Yeregorix force-pushed the refactor/damage-event branch from f202f5a to 84895e3 Compare December 30, 2024 22:05
@Yeregorix Yeregorix changed the base branch from api-12 to api-14 December 30, 2024 22:05
@Yeregorix Yeregorix force-pushed the refactor/damage-event branch from 84895e3 to a321867 Compare December 30, 2024 22:08
@Yeregorix Yeregorix force-pushed the refactor/damage-event branch from a321867 to 797c8c3 Compare January 25, 2025 10:57
@Yeregorix Yeregorix force-pushed the refactor/damage-event branch 2 times, most recently from a8c2298 to de4015f Compare February 11, 2025 20:33
@Yeregorix Yeregorix force-pushed the refactor/damage-event branch from de4015f to 18367fa Compare March 10, 2025 19:33
@Yeregorix Yeregorix force-pushed the refactor/damage-event branch from 18367fa to 98780cb Compare March 11, 2025 08:34
@Yeregorix Yeregorix force-pushed the refactor/damage-event branch from 1363974 to a5f7173 Compare March 11, 2025 16:26
@Yeregorix Yeregorix marked this pull request as ready for review March 11, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant