Add deprecation warning to ComponentSerializer.toString(Object) #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It taking all objects is error-prone, deprecate it and create overloads for used acceptable types.
md-5
reviewed
Apr 21, 2024
| return gson.toJson( content ); | ||
| } | ||
|
|
||
| public static String toString(JsonElement element) |
There was a problem hiding this comment.
Actually it is not used, oops. But it refers to the correct overload of gson for json elements.
md-5
reviewed
Apr 21, 2024
| public static String toString(Object object) | ||
| { | ||
| return gson.toJson( object ); | ||
| } | ||
|
|
||
| public static String toString(Content content) |
There was a problem hiding this comment.
Would plugins ever need this? Both seem kind of internal, can they be hidden away, package-private maybe?
There was a problem hiding this comment.
Can't make this package-private, its accessed from HoverEvent's deprecated getValue which is in api.chat while the serializer is only in chat.
Yes, plugins won't need it.
I'm not sure how to improve the situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It taking all objects is error-prone, deprecate it and create overloads for used acceptable types.