Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor done for docs file and added new pockets #37

Merged
merged 3 commits into from
Dec 11, 2020
Merged

refactor: refactor done for docs file and added new pockets #37

merged 3 commits into from
Dec 11, 2020

Conversation

damla
Copy link
Member

@damla damla commented Dec 11, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

  • Learned that md files doesn't need slug if they are already under a file. Therefore, changed the folder structure and adapted it to sidebars.js file.
  • Currently, style-guide.md is main page of docs therefore, it needs to stay under docs folder.
  • Didn't changed uncategorized file's places.

Related Tickets & Documents

#14

QA Instructions, Screenshots, Recordings

image

Added tests?

  • Yes
  • No, and this is why: Not required.
  • I need help with writing tests

Added to documentation?

  • Docs
  • README
  • No documentation needed

@damla damla added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 11, 2020
@damla damla added this to the v1.0.0 milestone Dec 11, 2020
@damla damla merged commit e9f84b9 into main Dec 11, 2020
@damla damla changed the title refactor: refactor: refactor done for docs file and added new pockets Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilter ilter Awaiting requested review from ilter

@omerayyildiz omerayyildiz Awaiting requested review from omerayyildiz

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request PR: merged
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@damla @ilter