Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 添加项目成员 #353

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: 添加项目成员 #353

wants to merge 5 commits into from

Conversation

liulijun4959
Copy link

@liulijun4959 liulijun4959 commented May 15, 2023 •
edited by ZhouYixun
Loading

Whether this PR is eventually merged or not, Sonic will thank you very much for your contribution.

无论此PR最终是否合并，Sonic组织都非常感谢您的贡献。

Checklist

  • The title starts with fix, fea, or doc. | 标题为fix、feat或doc开头。
  • I have checked that there are no duplicate pull requests with this request. | 我已检查没有与此请求重复的拉取请求。
  • I have considered and confirmed that this submission is valuable to others. | 我已经考虑过，并确认这份呈件对其他人很有价值。
  • I accept that this submission may not be used. | 我接受此提交可能不会被使用。

Description

@liulijun4959
优化代码：@Autowired 修改为 @resource
66e615c
@liulijun4959
优化代码：@Autowired 修改为 @resource
681cb72
@liulijun4959
增加项目成员功能
489d8f0 
1. 用户登录，修改成查找用户所属项目列表
2. 项目成员增删查功能
@liulijun4959
Copy link
Author

liulijun4959 commented May 15, 2023 •
edited
Loading

用户登录后可以看到所有的项目，且项目没有成员列表功能，考虑到实际情况，修改如下：

  1. 用户登录后，只能看到所属项目
  2. 项目增加成员列表功能
    image

@ZhouYixun
Copy link
Member

添加后你打算怎么鉴权呢？实际上之前我们有打算建设过 #317

@ZhouYixun ZhouYixun changed the title Dev feat: 添加项目成员 May 15, 2023
@prlabeler prlabeler bot added the feature label May 15, 2023
@liulijun4959
Copy link
Author

liulijun4959 commented May 15, 2023 •
edited
Loading

项目表加了一个创建人字段，可以用来鉴权，只有项目创建者才能做添加或删除成员，并且删除项目。。项目成员不能做这些操作

@liulijun4959
Copy link
Author

liulijun4959 commented May 15, 2023 •
edited
Loading

前端也提交代码了：/controller/projects/list（查所有项目） 改成 /controller/users/listProjects（根据用户id查所属项目）
image

@ZhouYixun
Copy link
Member

作用并不是那么大，因为里面的控件、用例等信息还是没有走鉴权

@liulijun4959
Copy link
Author

对的，可以考虑慢慢优化。近期部署sonic平台后，项目组同事就反馈了一些问题：登录之后可以看到所有的项目，而且没法查看项目组成员，最大的问题是都可以在项目设置页面进行删除，风险较大。所以我只是做了简单的修改，至少可以解决当下项目成员的问题

@ZhouYixun
Copy link
Member

对的，可以考虑慢慢优化。近期部署sonic平台后，项目组同事就反馈了一些问题：登录之后可以看到所有的项目，而且没法查看项目组成员，最大的问题是都可以在项目设置页面进行删除，风险较大。所以我只是做了简单的修改，至少可以解决当下项目成员的问题

这个先放着，设计上没有我们想得那么完美，我们还在看有没有更佳的方式，先感谢您这边的贡献，

@ZhouYixun ZhouYixun added good first issue Good for newcomers and removed good first issue Good for newcomers labels May 16, 2023
@ZhouYixun ZhouYixun mentioned this pull request May 16, 2023
Open
4 tasks
wl10201 added 2 commits July 19, 2023 19:28
Merge remote-tracking branch 'upstream/main' into dev
2de34e1 
# Conflicts:
#	sonic-server-controller/src/main/java/org/cloud/sonic/controller/models/domain/Projects.java
#	sonic-server-controller/src/main/java/org/cloud/sonic/controller/models/dto/ProjectsDTO.java
合并远程代码
17ff5c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liulijun4959 @ZhouYixun