Fix S6964 FN: Rule should raise in case of value type property annotated with RequiredAttribute #9313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
changed the title
|
@zsolt-kolbay-sonarsource - I haven't updated the ITs yet - I prefer to get the first round of review since, for example, the message or what we raise might change. |
zsolt-kolbay-sonarsource
approved these changes
May 24, 2024
| @@ -1,6 +1,7 @@ | |||
| using Microsoft.AspNetCore.Mvc; | |||
| using System; | |||
| using System.ComponentModel.DataAnnotations; | |||
| using System.Text.Json.Serialization; | |||
There was a problem hiding this comment.
Now that we know that [Required] doesn't affect value properties, please change this comment to:
// Compliant - the JSON serializer will throw an exception if the value is missing from the request
mary-georgiou-sonarsource
force-pushed
the
mary/S6964-last
branch
from
d91355b
to
adb42e8
Compare
mary-georgiou-sonarsource
changed the title
mary-georgiou-sonarsource
force-pushed
the
mary/S6964-last
branch
2 times, most recently
from
74c4793
to
68adace
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/S6964-last
branch
from
a81af70
to
2ad3e12
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9263
RSPEC PR: SonarSource/rspec#3942