Skip to content

fix: Make spawn process work on Windows #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Conversation

joachimvh
Copy link
Contributor

This would make my life easier.

The Windows installation of eye is done with a batch file, which requires this setting as noted in https://nodejs.org/api/child_process.html#spawning-bat-and-cmd-files-on-windows

I also changed the eye path in the test to eye from /usr/local/bin/eye so it is platform independent. Or does that break stuff for you?

@joachimvh joachimvh requested a review from woutslabbinck April 8, 2025 13:47
Copy link
Collaborator

@woutslabbinck woutslabbinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test script still works on my machine, so this change ensure ODRL evaluator can work with local eye on both windows and linux.

@woutslabbinck woutslabbinck merged commit e3ae8d0 into main Apr 8, 2025
12 checks passed
@woutslabbinck woutslabbinck deleted the fix/win-shell branch April 8, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants