Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disabling feature for Github, OVH and Mattermost services #565

Merged
merged 35 commits into from
Dec 6, 2023
Merged

feat: disabling feature for Github, OVH and Mattermost services #565

merged 35 commits into from
Dec 6, 2023

Conversation

matmut7
Copy link
Member

@matmut7 matmut7 commented Aug 23, 2023 •
edited
Loading

Todo:

  • tester Github
  • tester Mattermost
  • tester OVH avec et sans email user
  • supprimer modification de l'onboarding

Cette PR désactive le support du webhook Github en attendant #593

Terminaison automatique de la session utilisateur au moment de la désactivation :

  • Mattermost : oui
  • OVH : non, manuellement par l'API non plus
  • Github SSO :
    • Nextcloud : non, même après déconnexion manuelle ?
    • Zammad : non ?
    • Sentry : la page de login ne me propose pas le SSO ?
    • Matomo ?

Différents points d'UI/UX à revoir :

  • toaster plutôt que modal pour la réponse
  • afficher email du user maintenant qu'on enregistre celui de l'onboarding (actuellement on trouve parfois un email par certains services comme OVH)
  • ne pas proposer enable de OVH quand pas d'email connu. Pour l'instant on a le bouton et on prend une réponse négative du serveur

@matmut7 matmut7 force-pushed the feat/disable-user branch from 22a0565 to ade5a46 Compare August 23, 2023 09:36
@matmut7 matmut7 marked this pull request as draft August 23, 2023 09:36
@matmut7 matmut7 removed the request for review from gary-van-woerkens August 23, 2023 09:36
@matmut7 matmut7 temporarily deployed to review-auto August 23, 2023 09:37 — with GitHub Actions Inactive
@socket-security
Copy link

socket-security bot commented Aug 23, 2023 •
edited
Loading

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
vitest 0.34.6 eval, network, filesystem, shell, environment +72 251 MB oreanno
react-toastify 9.1.3 None +1 400 kB sniphpet
zod 3.21.4 None +0 604 kB colinmcd94
@vitejs/plugin-react 4.2.0 network +41 246 MB vitebot
@sentry/nextjs 7.32.1...7.84.0 None +14/-13 11 MB sentry-bot
msw 0.49.3...2.0.8 None +12/-17 1.4 MB kettanaito

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@matmut7 matmut7 force-pushed the feat/disable-user branch from 99723a6 to dfe61ed Compare August 23, 2023 10:11
@matmut7 matmut7 temporarily deployed to review-auto August 23, 2023 10:11 — with GitHub Actions Inactive
@matmut7 matmut7 force-pushed the feat/disable-user branch from dfe61ed to 0dc8592 Compare August 23, 2023 14:15
@matmut7 matmut7 temporarily deployed to review-auto August 23, 2023 14:15 — with GitHub Actions Inactive
@matmut7 matmut7 force-pushed the feat/disable-user branch from 0dc8592 to e3122ac Compare August 24, 2023 08:05
@matmut7 matmut7 temporarily deployed to review-auto August 24, 2023 08:05 — with GitHub Actions Inactive
@matmut7 matmut7 force-pushed the feat/disable-user branch from e3122ac to e1002d5 Compare August 24, 2023 08:22
@matmut7 matmut7 temporarily deployed to review-auto August 24, 2023 08:22 — with GitHub Actions Inactive
@matmut7 matmut7 temporarily deployed to review-auto September 5, 2023 12:44 — with GitHub Actions Inactive
@matmut7 matmut7 temporarily deployed to review-auto September 6, 2023 14:10 — with GitHub Actions Inactive
@matmut7 matmut7 temporarily deployed to review-auto September 22, 2023 08:23 — with GitHub Actions Inactive
@matmut7 matmut7 force-pushed the feat/disable-user branch 2 times, most recently from b709312 to 0831889 Compare October 11, 2023 12:47
@gary-van-woerkens gary-van-woerkens marked this pull request as ready for review December 6, 2023 11:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

🎉 Deployment for commit 77d66e8 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/secretariat/secretariat/app:sha-77d66e8531530ed74291c66fcdda322441fae091
  • 📦 docker pull harbor.fabrique.social.gouv.fr/secretariat/secretariat/hasura:sha-77d66e8531530ed74291c66fcdda322441fae091
Debug

@gary-van-woerkens gary-van-woerkens merged commit 5e30e3e into master Dec 6, 2023
11 checks passed
@gary-van-woerkens gary-van-woerkens deleted the feat/disable-user branch December 6, 2023 12:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

🎉 This PR is included in version 1.57.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary-van-woerkens gary-van-woerkens gary-van-woerkens approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matmut7 @revolunet @gary-van-woerkens @SocialGroovyBot