Skip to content

Feat metabase refactor#4123

Merged
pYassine merged 5 commits intomasterfrom
feat-metabase-refactor
May 6, 2026
Merged

Feat metabase refactor#4123
pYassine merged 5 commits intomasterfrom
feat-metabase-refactor

Conversation

@pYassine
Copy link
Copy Markdown
Contributor

@pYassine pYassine commented May 6, 2026

No description provided.

@revu-bot revu-bot Bot requested a review from revu-bot May 6, 2026 16:29
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 6, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedjest@​29.7.01001006892100
Added@​types/​sanitize-html@​2.16.01001007084100
Added@​babel/​runtime@​7.29.21001007996100

View full report

@pYassine pYassine marked this pull request as ready for review May 6, 2026 16:37
Copy link
Copy Markdown
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ PR Review Skipped

1 validation issue found. Review thresholds can be adjusted in .revu.yml.

See why it was skipped and detailed metrics

Issues Found

1. This PR changes 83 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

  • Total files changed: 83
  • Reviewable files: 83
  • Diff size: 5594 lines
  • Documentation files: 0
  • Largest file change: 522 lines
  • Addition/Deletion ratio: 1.29

This validation helps ensure the bot focuses on PRs where automated review provides the most value.

@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 16:42 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 16:42 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 16:42 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 16:42 — with GitHub Actions Inactive
@pYassine pYassine had a problem deploying to build-review-auto May 6, 2026 17:30 — with GitHub Actions Failure
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 17:30 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 17:30 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 17:30 — with GitHub Actions Inactive
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 6, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@pYassine pYassine had a problem deploying to build-review-auto May 6, 2026 17:48 — with GitHub Actions Failure
@pYassine pYassine had a problem deploying to build-review-auto May 6, 2026 17:48 — with GitHub Actions Failure
@pYassine pYassine had a problem deploying to build-review-auto May 6, 2026 17:48 — with GitHub Actions Failure
@pYassine pYassine had a problem deploying to build-review-auto May 6, 2026 17:48 — with GitHub Actions Failure
@pYassine pYassine force-pushed the feat-metabase-refactor branch from 3a75c72 to 5c949fb Compare May 6, 2026 18:16
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 18:16 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 18:16 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 18:16 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 18:16 — with GitHub Actions Inactive
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 6, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 52.33161% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.20%. Comparing base (fb8f7d7) to head (800c826).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ollers/national-stats/national-stats.controller.ts 22.72% 26 Missing and 8 partials ⚠️
...ontrollers/national-stats/metabase-embed.helper.ts 36.00% 27 Missing and 5 partials ⚠️
...nd/src/_migrations/1778077375651-auto-migration.ts 14.28% 18 Missing ⚠️
...c/usagers/controllers/search-usagers.controller.ts 33.33% 3 Missing and 1 partial ⚠️
...s/backend/src/modules/app-logs/app-logs.helpers.ts 88.88% 1 Missing ⚠️
...odules/portail-admin/services/check-territories.ts 96.42% 1 Missing ⚠️
...structures/controllers/structure-doc.controller.ts 50.00% 1 Missing ⚠️
...r-filter/checkers/usagerEcheanceChecker.service.ts 87.50% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
+ Coverage   62.36%   63.20%   +0.84%     
==========================================
  Files         954      957       +3     
  Lines       17459    17578     +119     
  Branches     2573     2581       +8     
==========================================
+ Hits        10888    11110     +222     
- Misses       6119     6212      +93     
+ Partials      452      256     -196     
Files with missing lines Coverage Δ
...c/auth/guards/app-throttler/app-throttler.guard.ts 23.52% <100.00%> (+2.31%) ⬆️
...ckend/src/auth/services/structures-auth.service.ts 92.00% <100.00%> (+0.16%) ⬆️
...c/database/entities/app-log/AppLogTable.typeorm.ts 100.00% <100.00%> (ø)
.../modules/mails/services/brevo-sync-cron.service.ts 24.59% <100.00%> (+1.25%) ⬆️
...rs/admin-structures/admin-structures.controller.ts 75.00% <100.00%> (+0.39%) ⬆️
.../controllers/admin-users/admin-users.controller.ts 53.62% <100.00%> (+0.68%) ⬆️
...gers-manager/portail-usagers-manager.controller.ts 21.62% <100.00%> (+0.71%) ⬆️
...gers-profile/portail-usagers-profile.controller.ts 68.96% <100.00%> (+0.54%) ⬆️
...ules/stats/controllers/stats.private.controller.ts 79.06% <100.00%> (+0.49%) ⬆️
...es/structures/controllers/structures.controller.ts 34.78% <100.00%> (+0.71%) ⬆️
... and 19 more

... and 81 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045607e...800c826. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pYassine pYassine force-pushed the feat-metabase-refactor branch from 5c949fb to 800c826 Compare May 6, 2026 22:00
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 22:00 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 22:00 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto May 6, 2026 22:00 — with GitHub Actions Inactive
@pYassine pYassine deployed to build-review-auto May 6, 2026 22:00 — with GitHub Actions Active
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@pYassine pYassine deployed to review-auto May 6, 2026 22:02 — with GitHub Actions Active
@tokenbureau
Copy link
Copy Markdown

tokenbureau Bot commented May 6, 2026

🎉 Deployment for commit 800c826 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-800c8266c6b9b6dd57f4c1ba9b242b7003f2b81f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-800c8266c6b9b6dd57f4c1ba9b242b7003f2b81f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-800c8266c6b9b6dd57f4c1ba9b242b7003f2b81f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-800c8266c6b9b6dd57f4c1ba9b242b7003f2b81f
Debug

@pYassine pYassine merged commit a4a6ac2 into master May 6, 2026
18 of 19 checks passed
@pYassine pYassine deleted the feat-metabase-refactor branch May 6, 2026 22:16
@tokenbureau
Copy link
Copy Markdown

tokenbureau Bot commented May 6, 2026

🎉 This PR is included in version 2.238.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau Bot added the released label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants