Skip to content

Conversation

@hbalty
Copy link
Contributor

@hbalty hbalty commented Jan 26, 2026

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot January 26, 2026 01:09
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:09 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:09 — with GitHub Actions Inactive
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: ## ⚠️ PR Review Skipped

3 validation issues found. Review thresholds can be adjusted in .revu.yml.

See why it was skipped and detailed metrics

Issues Found

1. This PR changes 166 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

2. This PR has 55375 lines of diff, which exceeds the limit of 15000 lines.

Suggestion: Consider splitting this PR into smaller chunks. Large diffs are difficult to review thoroughly and may hide important issues.

3. This PR contains files that exceed the size limit: 'yarn.lock' (29723 lines of changes), which exceeds the limit of 3000. The limit is 3000 lines per file.

Suggestion: Consider refactoring large changes into smaller, more focused modifications. Large file changes are harder to review and understand.

PR Metrics

  • Total files changed: 166
  • Reviewable files: 166
  • Diff size: 55375 lines
  • Documentation files: 0
  • Largest file change: 29723 lines
  • Addition/Deletion ratio: 6.62

This validation helps ensure the bot focuses on PRs where automated review provides the most value.

Revu logs

@socket-security
Copy link

socket-security bot commented Jan 26, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: npm form-data uses unsafe random function in form-data for choosing boundary

CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL)

Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4

Patched version: 2.5.4

From: ?npm/node-talisman@1.29.22npm/form-data@2.3.3

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/form-data@2.3.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm buffer is 96.0% likely obfuscated

Confidence: 0.96

Location: Package overview

From: ?npm/aws-sdk@2.1692.0npm/buffer@4.9.2

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/buffer@4.9.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:15 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:15 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:15 — with GitHub Actions Inactive
@hbalty hbalty force-pushed the feat-demo-public-domifa branch from d682101 to 8eabbe9 Compare January 26, 2026 01:20
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:21 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:21 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:21 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:21 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 75.81699% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.92%. Comparing base (d2fedc2) to head (cfa194b).

Files with missing lines Patch % Lines
...pp/modules/shared/directives/has-role.directive.ts 14.28% 18 Missing ⚠️
...ternational/input-phone-international.component.ts 87.41% 18 Missing ⚠️
.../modules/structures/utils/generateStructureForm.ts 21.42% 11 Missing ⚠️
...ormation/manage-structure-information.component.ts 25.00% 9 Missing ⚠️
packages/frontend/src/app/app-routing.module.ts 0.00% 3 Missing ⚠️
...onfidentialite/alerte-confidentialite.component.ts 76.92% 3 Missing ⚠️
...ules/auth/components/login/login-form.component.ts 50.00% 2 Missing ⚠️
...agments/login-dropdown/login-dropdown.component.ts 75.00% 2 Missing ⚠️
...nts/login-modal-menu/login-modal-menu.component.ts 66.66% 2 Missing ⚠️
...ules/general/components/navbar/navbar.component.ts 75.00% 2 Missing ⚠️
... and 3 more
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4064      +/-   ##
==========================================
+ Coverage   65.75%   65.92%   +0.16%     
==========================================
  Files         922      948      +26     
  Lines       16192    16436     +244     
  Branches     2273     2312      +39     
==========================================
+ Hits        10647    10835     +188     
- Misses       5212     5560     +348     
+ Partials      333       41     -292     
Files with missing lines Coverage Δ
packages/frontend/src/app/app.component.html 100.00% <ø> (ø)
...mation/manage-structure-information.component.html 100.00% <ø> (ø)
...nts/login-container/login-container.component.html 100.00% <100.00%> (ø)
...nents/login-container/login-container.component.ts 100.00% <100.00%> (ø)
...es/auth/components/login/login-form.component.html 100.00% <100.00%> (ø)
...nts/contact-support/contact-support.component.html 100.00% <100.00%> (ø)
.../modules/general/components/faq/faq.component.html 100.00% <100.00%> (ø)
...fragments/faq-discover/faq-discover.component.html 100.00% <100.00%> (ø)
...q/fragments/faq-discover/faq-discover.component.ts 100.00% <100.00%> (ø)
...faq/fragments/faq-fiches/faq-fiches.component.html 100.00% <100.00%> (ø)
... and 58 more

... and 118 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2fedc2...cfa194b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:40 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:40 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:40 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 26, 2026 01:40 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@tokenbureau
Copy link

tokenbureau bot commented Jan 26, 2026

🎉 Deployment for commit cfa194b :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-cfa194b69c4409a99175c31563dab4a0bbbba8e4
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-cfa194b69c4409a99175c31563dab4a0bbbba8e4
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-cfa194b69c4409a99175c31563dab4a0bbbba8e4
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-cfa194b69c4409a99175c31563dab4a0bbbba8e4
Debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants