Skip to content

Conversation

@hbalty
Copy link
Contributor

@hbalty hbalty commented Jan 23, 2026

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot January 23, 2026 22:30
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

This PR introduces a new authentication module with login and password reset functionality, implementing a modern DSFR-styled UI. The refactoring moves authentication components into a dedicated module with improved routing structure.

Critical Issues Found

  • Password visibility toggle not functional in login form (missing implementation)
  • Broken navigation route after password reset success
  • Missing ARIA labels for accessibility on password toggles

Positive Aspects

  • Good separation of concerns with new auth module
  • Consistent use of DSFR design system
  • Proper form validation implementation

Recommendations

  1. Fix the password visibility toggle functionality
  2. Correct the navigation route after password reset
  3. Add proper ARIA labels for accessibility
  4. Remove commented-out legacy code to improve maintainability

@hbalty hbalty force-pushed the feat-dsfr-login-frontend branch from 7de8eca to 8c5c70d Compare January 23, 2026 22:34
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:34 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:34 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:34 — with GitHub Actions Inactive
@hbalty hbalty force-pushed the feat-dsfr-login-frontend branch from 8c5c70d to c6baa48 Compare January 23, 2026 22:35
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:35 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:35 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:35 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:35 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.92%. Comparing base (df15f2b) to head (af5de69).

Files with missing lines Patch % Lines
...ules/auth/components/login/login-form.component.ts 50.00% 2 Missing ⚠️
packages/frontend/src/app/app-routing.module.ts 0.00% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           feat-init-frontend-dsfr    #4062      +/-   ##
===========================================================
- Coverage                    65.94%   65.92%   -0.03%     
===========================================================
  Files                          927      929       +2     
  Lines                        16342    16342              
  Branches                      2303     2305       +2     
===========================================================
- Hits                         10777    10773       -4     
- Misses                        5376     5528     +152     
+ Partials                       189       41     -148     
Files with missing lines Coverage Δ
...nts/login-container/login-container.component.html 100.00% <100.00%> (ø)
...nents/login-container/login-container.component.ts 100.00% <100.00%> (ø)
...es/auth/components/login/login-form.component.html 100.00% <100.00%> (ø)
...frontend/src/app/modules/general/general.module.ts 100.00% <ø> (ø)
...d-form/user-structure-password-form.component.html 100.00% <100.00%> (ø)
...ord-form/user-structure-password-form.component.ts 80.95% <100.00%> (ø)
...s/frontend/src/app/modules/shared/shared.module.ts 100.00% <100.00%> (ø)
...nents/reset-password/reset-password.component.html 100.00% <100.00%> (ø)
...tend/src/app/modules/users/users-routing.module.ts 100.00% <ø> (ø)
...ges/frontend/src/app/modules/users/users.module.ts 100.00% <ø> (ø)
... and 2 more

... and 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df15f2b...af5de69. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hbalty hbalty force-pushed the feat-dsfr-login-frontend branch from c6baa48 to af5de69 Compare January 23, 2026 22:52
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:52 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:52 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:52 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 23, 2026 22:52 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@tokenbureau
Copy link

tokenbureau bot commented Jan 23, 2026

🎉 Deployment for commit af5de69 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-af5de691727c275b5b9f1feb7e13e5b094eee52a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-af5de691727c275b5b9f1feb7e13e5b094eee52a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-af5de691727c275b5b9f1feb7e13e5b094eee52a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-af5de691727c275b5b9f1feb7e13e5b094eee52a
Debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants