-
Notifications
You must be signed in to change notification settings - Fork 10
feat(frontend): integrating login and password reset #4062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat-init-frontend-dsfr
Are you sure you want to change the base?
Conversation
revu-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Summary
This PR introduces a new authentication module with login and password reset functionality, implementing a modern DSFR-styled UI. The refactoring moves authentication components into a dedicated module with improved routing structure.
Critical Issues Found
- Password visibility toggle not functional in login form (missing implementation)
- Broken navigation route after password reset success
- Missing ARIA labels for accessibility on password toggles
Positive Aspects
- Good separation of concerns with new auth module
- Consistent use of DSFR design system
- Proper form validation implementation
Recommendations
- Fix the password visibility toggle functionality
- Correct the navigation route after password reset
- Add proper ARIA labels for accessibility
- Remove commented-out legacy code to improve maintainability
packages/frontend/src/app/modules/users/components/reset-password/reset-password.component.html
Show resolved
Hide resolved
packages/frontend/src/app/modules/auth/components/login/login-form.component.html
Show resolved
Hide resolved
packages/frontend/src/app/modules/users/components/reset-password/reset-password.component.html
Show resolved
Hide resolved
7de8eca to
8c5c70d
Compare
8c5c70d to
c6baa48
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-init-frontend-dsfr #4062 +/- ##
===========================================================
- Coverage 65.94% 65.92% -0.03%
===========================================================
Files 927 929 +2
Lines 16342 16342
Branches 2303 2305 +2
===========================================================
- Hits 10777 10773 -4
- Misses 5376 5528 +152
+ Partials 189 41 -148
... and 66 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
c6baa48 to
af5de69
Compare
|




No description provided.