Skip to content

Conversation

@hbalty
Copy link
Contributor

@hbalty hbalty commented Dec 22, 2025

No description provided.

Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: ## ⚠️ PR Review Skipped

1 validation issue found. Review thresholds can be adjusted in .revu.yml.

See why it was skipped and detailed metrics

Issues Found

1. This PR changes 28 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

  • Total files changed: 28
  • Reviewable files: 28
  • Diff size: 5498 lines
  • Documentation files: 0
  • Largest file change: 1999 lines
  • Addition/Deletion ratio: 0.62

This validation helps ensure the bot focuses on PRs where automated review provides the most value.

Revu logs

@hbalty hbalty force-pushed the feat-dsfr-pages-statiques-frontend branch from e602668 to f13fc00 Compare December 22, 2025 22:02
@hbalty hbalty temporarily deployed to build-review-auto December 22, 2025 22:02 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto December 22, 2025 22:02 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto December 22, 2025 22:02 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat-init-frontend-dsfr@76e52c7). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##             feat-init-frontend-dsfr    #4045   +/-   ##
==========================================================
  Coverage                           ?   65.92%           
==========================================================
  Files                              ?      927           
  Lines                              ?    16353           
  Branches                           ?     2302           
==========================================================
  Hits                               ?    10781           
  Misses                             ?     5242           
  Partials                           ?      330           
Files with missing lines Coverage Δ
...eral/components/plan-site/plan-site.component.html 100.00% <100.00%> (ø)
...ral/components/static-pages/cgu/cgu.component.html 100.00% <100.00%> (ø)
...s/mentions-legales/mentions-legales.component.html 100.00% <100.00%> (ø)
...ts/static-pages/politique/politique.component.html 100.00% <100.00%> (ø)
...l/components/static-pages/rgaa/rgaa.component.html 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e52c7...0350049. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pYassine pYassine force-pushed the feat-init-frontend-dsfr branch 2 times, most recently from 9913a24 to 0b02941 Compare December 30, 2025 13:29
@pYassine pYassine force-pushed the feat-dsfr-pages-statiques-frontend branch from f13fc00 to 64a1b69 Compare January 4, 2026 21:13
@hbalty hbalty force-pushed the feat-dsfr-pages-statiques-frontend branch from 64a1b69 to e184e11 Compare January 13, 2026 22:47
@hbalty hbalty temporarily deployed to build-review-auto January 13, 2026 22:47 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 13, 2026 22:47 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 13, 2026 22:47 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 13, 2026 22:47 — with GitHub Actions Inactive
@socket-security
Copy link

socket-security bot commented Jan 13, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: npm form-data uses unsafe random function in form-data for choosing boundary

CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL)

Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4

Patched version: 2.5.4

From: ?npm/node-talisman@1.29.22npm/form-data@2.3.3

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/form-data@2.3.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm buffer is 96.0% likely obfuscated

Confidence: 0.96

Location: Package overview

From: ?npm/aws-sdk@2.1692.0npm/buffer@4.9.2

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/buffer@4.9.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@tokenbureau
Copy link

tokenbureau bot commented Jan 15, 2026

🎉 Deployment for commit 446c22d :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-446c22de9a69e562a75957acd3adee87243517b5
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-446c22de9a69e562a75957acd3adee87243517b5
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-446c22de9a69e562a75957acd3adee87243517b5
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-446c22de9a69e562a75957acd3adee87243517b5
Debug

@pYassine pYassine force-pushed the feat-init-frontend-dsfr branch from ec86e7c to 517f003 Compare January 18, 2026 23:38
@hbalty hbalty force-pushed the feat-dsfr-pages-statiques-frontend branch from 446c22d to 7b55249 Compare January 19, 2026 16:30
@hbalty hbalty temporarily deployed to build-review-auto January 19, 2026 16:30 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 19, 2026 16:30 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 19, 2026 16:30 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the feat-init-frontend-dsfr branch from 517f003 to 6761767 Compare January 20, 2026 14:00
@hbalty hbalty force-pushed the feat-dsfr-pages-statiques-frontend branch from 7b55249 to 57cbce0 Compare January 24, 2026 01:41
@hbalty hbalty temporarily deployed to build-review-auto January 24, 2026 01:41 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 24, 2026 01:41 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 24, 2026 01:41 — with GitHub Actions Inactive
@hbalty hbalty force-pushed the feat-dsfr-pages-statiques-frontend branch from 57cbce0 to 0350049 Compare January 24, 2026 02:10
@hbalty hbalty temporarily deployed to build-review-auto January 24, 2026 02:10 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 24, 2026 02:10 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto January 24, 2026 02:10 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants