-
Notifications
You must be signed in to change notification settings - Fork 10
feat(front): integrating header dsfr #4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat-init-frontend-dsfr
Are you sure you want to change the base?
feat(front): integrating header dsfr #4040
Conversation
revu-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
This PR integrates the French government's DSFR (Système de Design de l'État) header component, replacing the custom navbar with standardized components. The implementation includes:
- ✅ New DSFR dropdown menu components for desktop and mobile
- ✅ Role-based access control directive
- ✅ Matomo privacy notice component
⚠️ CRITICAL: Missing reactive updates inHasRoleDirective⚠️ IMPORTANT: Inconsistent logout method calls⚠️ IMPORTANT: Unused input binding inLoginModalMenuComponent
Key Issues
| Severity | Count | Category |
|---|---|---|
| CRITICAL | 1 | Reactivity bug |
| IMPORTANT | 2 | API inconsistency, unused code |
The DSFR integration is well-structured, but the role directive needs immediate attention to prevent authorization bugs.
packages/frontend/src/app/modules/shared/directives/has-role.directive.ts
Show resolved
Hide resolved
...p/modules/general/components/navbar/fragments/login-modal-menu/login-modal-menu.component.ts
Outdated
Show resolved
Hide resolved
...p/modules/general/components/navbar/fragments/login-modal-menu/login-modal-menu.component.ts
Show resolved
Hide resolved
packages/frontend/src/app/modules/general/components/navbar/navbar.component.html
Show resolved
Hide resolved
packages/frontend/src/app/modules/general/components/navbar/navbar.component.ts
Show resolved
Hide resolved
3c86c7d to
a14f009
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-init-frontend-dsfr #4040 +/- ##
==========================================================
Coverage ? 65.89%
==========================================================
Files ? 934
Lines ? 16407
Branches ? 2310
==========================================================
Hits ? 10811
Misses ? 5265
Partials ? 331
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
a14f009 to
51c43a7
Compare
51c43a7 to
f16bd28
Compare
...app/modules/general/components/navbar/fragments/login-dropdown/login-dropdown.component.html
Outdated
Show resolved
Hide resolved
...app/modules/general/components/navbar/fragments/login-dropdown/login-dropdown.component.html
Show resolved
Hide resolved
| <!-- <script async src="https://tally.so/widgets/embed.js"></script> --> | ||
| <script> | ||
| // Options disponibles à l'initialisation du DSFR | ||
| window.dsfr = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hbalty quel est le but de cette variable ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ça sert à définir le mode d'opération du module js dsfr. J'ai mis un commentaire dans le navbar avec l'url : https://www.systeme-de-design.gouv.fr/version-courante/fr/composants/en-tete/code-de-l-en-tete#variante-avec-raccourcis-dupliques-pour-angular-react-et-vue
Le menu en mobile ne fonctionne pas sans cette bidule parce que la dom est modifiée par dsfr ce qui fais des erreurs undefined pour angular.
packages/frontend/src/app/modules/general/components/navbar/navbar.component.html
Outdated
Show resolved
Hide resolved
Update packages/frontend/jest.config.js Co-authored-by: Revu <dnum.fabrique@sg.social.gouv.fr> fix(front): adding yar.lock changes fix(frontend): fix jest tranformPattern
2b6d2d0 to
1162fef
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
1162fef to
ab5abe5
Compare
ab5abe5 to
67e28a1
Compare
67e28a1 to
d361ac6
Compare
|




No description provided.