Skip to content

Conversation

@pYassine
Copy link
Contributor

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot September 24, 2025 08:22
@pYassine pYassine changed the title feat(frontend): start DSFR 🎨 DSFR - Frontend - Branche principale ⭐ Sep 24, 2025
@pYassine pYassine marked this pull request as ready for review September 24, 2025 08:22
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: Command failed: git clone https://x-access-token:ghs_83nL6D2UEBJ405UvY3t1CUoqsekKJn2YMPvh@github.com/SocialGouv/domifa.git /tmp/revu-repos-3933-1758702154439 --branch feat-init-frontend-dsfr
Cloning into '/tmp/revu-repos-3933-1758702154439'...
fatal: unable to access 'https://github.com/SocialGouv/domifa.git/': server certificate verification failed. CAfile: none CRLfile: none

Revu logs

@sonarqubecloud
Copy link

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 83.03030% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.94%. Comparing base (d2fedc2) to head (df15f2b).

Files with missing lines Patch % Lines
...ternational/input-phone-international.component.ts 87.41% 18 Missing ⚠️
...ormation/manage-structure-information.component.ts 25.00% 9 Missing ⚠️
...nents/contact-support/contact-support.component.ts 66.66% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3933      +/-   ##
==========================================
+ Coverage   65.75%   65.94%   +0.19%     
==========================================
  Files         922      927       +5     
  Lines       16192    16342     +150     
  Branches     2273     2303      +30     
==========================================
+ Hits        10647    10777     +130     
- Misses       5212     5376     +164     
+ Partials      333      189     -144     
Files with missing lines Coverage Δ
packages/frontend/src/app/app.component.html 100.00% <ø> (ø)
...mation/manage-structure-information.component.html 100.00% <ø> (ø)
...nts/contact-support/contact-support.component.html 100.00% <100.00%> (ø)
...odules/general/components/home/home.component.html 100.00% <ø> (ø)
...eral/components/plan-site/plan-site.component.html 100.00% <ø> (ø)
...eneral/components/plan-site/plan-site.component.ts 100.00% <ø> (ø)
...src/app/modules/shared/constants/FA_ICONS.const.ts 100.00% <ø> (ø)
...s/frontend/src/app/modules/shared/shared.module.ts 100.00% <100.00%> (ø)
.../components/step-header/step-header.component.html 100.00% <ø> (ø)
...ofil-edit-portail-usager-preference.component.html 100.00% <ø> (ø)
... and 10 more

... and 60 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2fedc2...df15f2b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pYassine pYassine force-pushed the feat-init-frontend-dsfr branch from 7f4fc74 to ba837b8 Compare November 19, 2025 15:38
@pYassine pYassine temporarily deployed to build-review-auto November 19, 2025 15:38 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto November 19, 2025 15:38 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto November 19, 2025 15:38 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the feat-init-frontend-dsfr branch from ba837b8 to c60ee94 Compare December 11, 2025 22:15
@pYassine pYassine temporarily deployed to build-review-auto December 11, 2025 22:15 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto December 11, 2025 22:15 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto December 11, 2025 22:15 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto December 19, 2025 12:04 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto December 19, 2025 12:04 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto December 19, 2025 12:04 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto December 19, 2025 12:04 — with GitHub Actions Inactive
@socket-security
Copy link

socket-security bot commented Dec 19, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@hbalty hbalty force-pushed the feat-init-frontend-dsfr branch from c21bab5 to 3fbb75c Compare December 19, 2025 12:21
@hbalty hbalty temporarily deployed to build-review-auto December 19, 2025 12:21 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto December 19, 2025 12:21 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto December 19, 2025 12:21 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto December 19, 2025 12:21 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the feat-init-frontend-dsfr branch from 3fbb75c to 39c3d25 Compare December 21, 2025 21:38
@pYassine pYassine temporarily deployed to build-review-auto December 21, 2025 21:38 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the feat-init-frontend-dsfr branch from 517f003 to 6761767 Compare January 20, 2026 13:59
@pYassine pYassine temporarily deployed to build-review-auto January 20, 2026 14:00 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto January 20, 2026 14:00 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto January 20, 2026 14:00 — with GitHub Actions Inactive
@socket-security
Copy link

socket-security bot commented Jan 22, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedjest@​29.7.01001006891100
Added@​edugouvfr/​ngx-dsfr@​1.15.0751001009490
Added@​edugouvfr/​ngx-dsfr-ext@​1.5.1771001009490

View full report

@tokenbureau
Copy link

tokenbureau bot commented Jan 22, 2026

🎉 Deployment for commit df15f2b :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-df15f2bdc373a3af0b1271620749b41dd0624259
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-df15f2bdc373a3af0b1271620749b41dd0624259
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-df15f2bdc373a3af0b1271620749b41dd0624259
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-df15f2bdc373a3af0b1271620749b41dd0624259
Debug

hbalty and others added 5 commits January 24, 2026 00:41
Update packages/frontend/jest.config.js

Co-authored-by: Revu <dnum.fabrique@sg.social.gouv.fr>

fix(front): adding yar.lock changes

fix(frontend): fix jest tranformPattern
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants