Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): add edit form for docs #3524

Merged
merged 5 commits into from
Oct 30, 2024
Merged

fix(frontend): add edit form for docs #3524

merged 5 commits into from
Oct 30, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review October 29, 2024 22:48
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 38.70968% with 171 lines in your changes missing coverage. Please review.

Project coverage is 67.14%. Comparing base (c2c3b01) to head (be58aba).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...gers-profile/portail-usagers-profile.controller.ts 38.88% 32 Missing and 1 partial ⚠️
...splay-usager-docs/display-usager-docs.component.ts 4.00% 24 Missing ⚠️
...cture-documents/profil-structure-docs.component.ts 4.76% 17 Missing and 3 partials ⚠️
...nents/edit-usager-doc/edit-usager-doc.component.ts 51.21% 19 Missing and 1 partial ⚠️
...backend/src/auth/guards/usager-doc-access.guard.ts 23.80% 15 Missing and 1 partial ⚠️
.../src/usagers/controllers/usager-docs.controller.ts 38.09% 12 Missing and 1 partial ⚠️
...nd/src/_migrations/1730216743164-auto-migration.ts 23.07% 9 Missing and 1 partial ⚠️
...cs-table/structures-custom-docs-table.component.ts 0.00% 9 Missing ⚠️
...kend/src/util/file-manager/file-manager.service.ts 33.33% 6 Missing ⚠️
...gers-manager/portail-usagers-manager.controller.ts 0.00% 4 Missing ⚠️
... and 9 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3524      +/-   ##
==========================================
- Coverage   67.30%   67.14%   -0.17%     
==========================================
  Files         895      904       +9     
  Lines       14769    14906     +137     
  Branches     2097     2115      +18     
==========================================
+ Hits         9940    10008      +68     
+ Misses       4674     4610      -64     
- Partials      155      288     +133
Files with missing lines Coverage Δ
packages/backend/src/_common/model/usager/index.ts 100.00% <ø> (ø)
packages/backend/src/auth/auth.module.ts 100.00% <ø> (ø)
packages/backend/src/auth/decorators/index.ts 100.00% <100.00%> (ø)
...ckend/src/auth/guards/CanGetUserStructure.guard.ts 90.47% <ø> (ø)
packages/backend/src/auth/guards/index.ts 100.00% <100.00%> (ø)
...atabase/entities/usager/UsagerDocsTable.typeorm.ts 100.00% <100.00%> (ø)
...se/services/usager/usagerDocsRepository.service.ts 100.00% <100.00%> (ø)
...s/backend/src/modules/app-logs/app-logs.service.ts 100.00% <100.00%> (ø)
.../modules/portail-usagers/portail-usagers.module.ts 100.00% <100.00%> (ø)
...structures/controllers/structure-doc.controller.ts 38.18% <ø> (ø)
... and 36 more

... and 53 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c3b01...be58aba. Read the comment docs.

@socket-security Socket Security
Copy link

socket-security bot commented Oct 30, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nestjs/[email protected] None 0 20.2 kB nestjscore
npm/@nestjs/[email protected] None 0 31.8 kB kamilmysliwiec, nestjscore
npm/@nestjs/[email protected] Transitive: eval, network +4 32.8 MB kamilmysliwiec, nestjscore
npm/@nestjs/[email protected] None 0 429 kB nestjscore
npm/@nestjs/[email protected] Transitive: environment, filesystem, network, shell +1 546 kB nestjscore
npm/@nestjs/[email protected] None 0 51 kB nestjscore
npm/@nestjs/[email protected] None 0 24.4 kB nestjscore
npm/@nestjs/[email protected] None 0 21.2 kB nestjscore
npm/@nestjs/[email protected] None 0 62.8 kB kamilmysliwiec, nestjscore
npm/@nestjs/[email protected] None 0 48.6 kB nestjscore
npm/@nestjs/[email protected] Transitive: eval, network +4 1.13 MB kamilmysliwiec, nestjscore
npm/@nestjs/[email protected] None +1 2.99 MB nestjscore
npm/@nestjs/[email protected] Transitive: filesystem +3 2.86 MB brunnerlivio
npm/@nestjs/[email protected] None 0 35.4 kB nestjscore
npm/@opentelemetry/[email protected] None 0 1.22 MB pichlermarc
npm/@opentelemetry/[email protected] None 0 909 kB bogdandrutu, dyladan, pichlermarc
npm/@opentelemetry/[email protected] Transitive: filesystem +2 688 kB dyladan
npm/@opentelemetry/[email protected] Transitive: filesystem +2 773 kB pichlermarc
npm/@opentelemetry/[email protected] Transitive: filesystem +2 650 kB dyladan
npm/@opentelemetry/[email protected] network Transitive: filesystem +2 654 kB dyladan
npm/@opentelemetry/[email protected] Transitive: filesystem +3 734 kB dyladan
npm/@opentelemetry/[email protected] environment Transitive: filesystem, network, shell, unsafe +22 17 MB pichlermarc
npm/@opentelemetry/[email protected] None 0 5.34 MB pichlermarc

🚮 Removed packages: npm/@eslint-community/[email protected], npm/@eslint/[email protected], npm/@eslint/[email protected], npm/@humanwhocodes/[email protected], npm/@humanwhocodes/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@ungap/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@github-actions GitHub Actions
Copy link

🎉 Deployment for commit a21e9cc :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-a21e9ccc6c11e96a23a2b965fec02cd35a0b6891
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-a21e9ccc6c11e96a23a2b965fec02cd35a0b6891
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-a21e9ccc6c11e96a23a2b965fec02cd35a0b6891
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-a21e9ccc6c11e96a23a2b965fec02cd35a0b6891
Debug

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@pYassine pYassine merged commit 13ea0e6 into master Oct 30, 2024
10 of 12 checks passed
@pYassine pYassine deleted the feat-edit-document branch October 30, 2024 17:25
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.182.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pYassine @codecov-commenter @SocialGroovyBot