Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix usager-docs download #3460

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix(frontend): fix usager-docs download #3460

merged 1 commit into from
Aug 28, 2024

Conversation

pYassine
Copy link
Contributor

No description provided.

Copy link

🎉 Deployment for commit ad8f4e0 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-ad8f4e0ff59df3bf07ba7da970c295519c3b411d
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-ad8f4e0ff59df3bf07ba7da970c295519c3b411d
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-ad8f4e0ff59df3bf07ba7da970c295519c3b411d
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-ad8f4e0ff59df3bf07ba7da970c295519c3b411d
Debug

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.65%. Comparing base (158ea3d) to head (ad8f4e0).
Report is 3 commits behind head on master.

Files Patch % Lines
...s/base-usager-notes/base-usager-notes.component.ts 0.00% 9 Missing ⚠️
...dossier-page/base-usager-dossier-page.component.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3460      +/-   ##
==========================================
- Coverage   66.66%   66.65%   -0.02%     
==========================================
  Files         922      922              
  Lines       15193    15194       +1     
  Branches     2151     2148       -3     
==========================================
- Hits        10129    10127       -2     
+ Misses       4911     4886      -25     
- Partials      153      181      +28     
Files Coverage Δ
...controllers/export-structure-usagers.controller.ts 90.00% <100.00%> (-0.63%) ⬇️
...ponents/step-decision/step-decision.component.html 100.00% <ø> (ø)
...nents/step-documents/step-documents.component.html 100.00% <ø> (ø)
...lay-usager-docs/display-usager-docs.component.html 100.00% <ø> (ø)
...dossier-page/base-usager-dossier-page.component.ts 75.60% <0.00%> (-1.90%) ⬇️
...s/base-usager-notes/base-usager-notes.component.ts 72.50% <0.00%> (-3.82%) ⬇️

... and 124 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158ea3d...ad8f4e0. Read the comment docs.

@pYassine pYassine merged commit 9e459ff into master Aug 28, 2024
16 checks passed
@pYassine pYassine deleted the fix-scroll-manage branch August 28, 2024 11:43
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.173.28 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants