Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): ajout de ressources et d'un replica sur le backend #2939

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

pYassine
Copy link
Contributor

@pYassine pYassine commented Sep 4, 2023

No description provided.

@pYassine pYassine requested a review from revolunet September 4, 2023 16:53
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2023

Codecov Report

Merging #2939 (7e5e499) into master (88ad64b) will increase coverage by 0.02%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2939      +/-   ##
==========================================
+ Coverage   68.01%   68.03%   +0.02%     
==========================================
  Files         918      919       +1     
  Lines       14577    14580       +3     
  Branches     2129     2127       -2     
==========================================
+ Hits         9914     9919       +5     
+ Misses       4392     4391       -1     
+ Partials      271      270       -1     
Files Changed Coverage
...c/structures/services/structure-deletor.service.ts ø
...rs/controllers/usager-structure-docs.controller.ts ø
packages/backend/src/users/dto/user.dto.ts ø
.../src/usagers/controllers/usager-docs.controller.ts 100.00%
...ers/services/custom-docs/buildCustomDoc.service.ts 100.00%
packages/backend/src/users/dto/user-edit.dto.ts 100.00%
...d/src/util/expressResponseExcelRenderer.service.ts 100.00%
...rontend/src/app/modules/shared/directives/index.ts 100.00%
...app/modules/shared/pipes/format-big-number.pipe.ts 100.00%
...ges/frontend/src/app/modules/shared/pipes/index.ts 100.00%
... and 1 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46db82...7e5e499. Read the comment docs.

@revolunet
Copy link
Member

En regardant sur grafana

Tous les workloads :

Capture d’écran 2023-09-04 à 22 50 16

Backend-cron uniquement :

Capture d’écran 2023-09-04 à 22 52 32

Au vu des chiffres, je propose quelques changements

@pYassine pYassine merged commit 0dd654f into master Sep 5, 2023
7 of 8 checks passed
@pYassine pYassine deleted the fix-api-perf branch September 5, 2023 10:01
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.134.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants