[API Break] Make control::property::Info::value_type return & instead of clone
#217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems odd for this to return an owned value, when `::name()` doesn't. And it is useful to get a reference to the `ValueType`, so `ValueType::convert_value` can be used and just use the lifetime of the `Info` instead of the cloned `ValueType.` I assume there's no reason not to do this, since callers can still clone as needed.
|
It was probably intended as a cheap Copy type, except that the presence of EnumValues (with Vecs) no longer makes that cheaply possible? |
|
Yeah, I was wondering about that, but haven't check the history. If it were a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems odd for this to return an owned value, when
::name()doesn't. And it is useful to get a reference to theValueType, soValueType::convert_valuecan be used and just use the lifetime of theInfoinstead of the clonedValueType.I assume there's no reason not to do this, since callers can still clone as needed.
As a small API break, I think this should be merged whenever the next semver bump to the crate happens to be.