Skip to content

Code cleanup #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Code cleanup #1

wants to merge 3 commits into from

Conversation

haho12
Copy link

@haho12 haho12 commented Oct 9, 2024

Hi,
I really liked your implementation and I will use it for my lectures / exercises at Hannover University of Applied Sciences, Germany.
Here's some suggestions:

  • make it run "out-of-the-box".
  • more readable different cases
  • use essential matrix E (working with normalized camera coordinates) instead of fundamental matrix (working with image coordinates)
  • decompose E to get rotation matrix R and translation vector t
    Btw. I also like your pictures very much. Would you add a license to use them, e.g. CC share-alike?
    Greetings,
    Hanno

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant