Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that dangerous, since it will also include content types that are not necessarily supported?
For example:
application/ vnd.openxmlformats-officedocument. wordprocessingml.document
which is the MIME-Type of a MS Word .docx file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wilk-polarny This is a score to indicate which tab to choose when the response comes. You can switch to XML tab manually anyway. So, this is not a security measure against an invalid content. The main purpose is to open xml tab when the xml has come in response. The current issue is that the hint is not working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the current proposal is sufficient, but if the hold-up is because of how open-ended it is, we could tighten it up by checking to see if it ends in "xml" or if it contains "/xml;". A regular expression such as the following would work: (?:(xml$)|(/xml;.+)) It is unclear to me--is the "WhiteSource Configuration Change" issue still outstanding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmccarty-incomm The issue is that the maintainers do not process the merge requests. Whitesource validation failure is a minor issue which can be resolved easilly as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about split by ";" and check it?