Added put to possible redirect message type. #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a put is redirected currently it drops into the else block that sets getMethod to ExtendedGetMethod. Added put as an option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a put is redirected currently it drops into the else block that sets getMethod to ExtendedGetMethod. Added put as an option.
I think potentially this should involve all request types and reuse the switch from createHttpMethod around line 430. Currently if you have a site that redirects and try to run a put the put flops to a get in the old else block. It looks like someone fixed it for post but never added other verbs or thought they would not be applicable. I believe all of them could redirect and drop into the followRedirects method.