Fix detailed display of WSDL mock response time outs #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior logic means that null mock result used to be supplied to the AssertedWsdlMockResultMessageExchange when mock response step timed out. Neither AbstractMessageExchange, not ShowMessageExchangeAction were ready for that. The patch: - adds support for null modelItem to AbstractMessageExchange (which used to be supported some time ago). However, this change ends up not being used due to change below; - adds support for null message exchange to ShowMessageExchangeAction as it is way to easier handle such condition there than support null mock result in WsdlMockResponseMessageExchange. Make appropriate changes in WsdlMockResponseTestStep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior logic means that null mock result used to be supplied to the
AssertedWsdlMockResultMessageExchange when mock response step timed out.
Neither AbstractMessageExchange, not ShowMessageExchangeAction were
ready for that.
The patch:
adds support for null modelItem to AbstractMessageExchange (which used
to be supported some time ago). However, this change ends up not being
used due to change below;
adds support for null message exchange to ShowMessageExchangeAction as
it is way to easier handle such condition there than support null mock
result in WsdlMockResponseMessageExchange. Make appropriate changes in
WsdlMockResponseTestStep.