-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Gemini Api Integration #150
Conversation
if SettingsManager.get_settings().ENABLE_GEMINI: | ||
LLMConfigRegistry.register_config( | ||
"GEMINI_GPT4V", | ||
litellm.completion("gpt-4-vision-preview", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
litellm.completion("gpt-4-vision-preview", | |
LLMConfig("gemini/gemini-pro", |
According to this https://litellm.vercel.app/docs/providers/gemini
@@ -72,3 +72,11 @@ def get_config(cls, llm_key: str) -> LLMRouterConfig | LLMConfig: | |||
True, | |||
), | |||
) | |||
if SettingsManager.get_settings().ENABLE_GEMINI: | |||
LLMConfigRegistry.register_config( | |||
"GEMINI_GPT4V", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"GEMINI_GPT4V", | |
"GOOGLE_GEMINI_PRO", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you running it within an active poetry shell?
first run, poetry shell, then run the precommit command. let me know how it goes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have a check that makes sure at least one provider is enabled. You need to update here as well:
I think you also need to do |
i have made changes please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for going over some of the review comments.
I added some more. Please let me know if anything's not clear
@@ -72,3 +74,12 @@ def get_config(cls, llm_key: str) -> LLMRouterConfig | LLMConfig: | |||
True, | |||
), | |||
) | |||
if SettingsManager.get_settings().ENABLE_GEMINI: | |||
LLMConfigRegistry.register_config( | |||
"GEMINI_GPT4V", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"GEMINI_GPT4V", | |
"GEMINI_PRO_VISION", |
Co-authored-by: Kerem Yilmaz <[email protected]>
Co-authored-by: Kerem Yilmaz <[email protected]>
merged |
This pull request is stale because it has been open for 14 days with no activity. |
@@ -61,14 +61,15 @@ class Settings(BaseSettings): | |||
# LLM Configuration # | |||
##################### | |||
# ACTIVE LLM PROVIDER | |||
LLM_KEY: str = "OPENAI_GPT4V" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the default llm_key as OPENAI_GPT4V
as this is the most reliable model that's been well tested by the skyvern team?
# COMMON | ||
LLM_CONFIG_MAX_TOKENS: int = 4096 | ||
LLM_CONFIG_TEMPERATURE: float = 0 | ||
# LLM PROVIDER SPECIFIC | ||
ENABLE_OPENAI: bool = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same. let's keep this True
This pull request is stale because it has been open for 14 days with no activity. |
completed Gemin Api Integration on Skyvern