feat!(clone): Use better cloning policy #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new function IsPushable to check if a user has push permissions based on the viewerPermission API query. Added new util file in the github package to include helper functions and facilitate unit testing on command outputs.
- Deprecated the `nofork` flag in favour of a `fork` one - Default Clone behaviour is branching instead of forking - Modified tests to reflect the changes in the clone command.
Updated the README to clarify the usage of the `turbolift clone` command.
This commit fixes the logic for forking and cloning repositories. Also changed the testing logic to include the type of call for GH. This is because the testing was just on the argument and was missing context when running the unit test.
sledigabel
commented
Oct 23, 2024
sledigabel
commented
Oct 23, 2024
sledigabel
commented
Oct 23, 2024
rnorth
reviewed
Oct 23, 2024
Updated the IsPushable function to use the full repository name instead of the repository directory path. The gh command now uses a repository as a parameter, since the clone has not taken place yet.
Added a new test to verify behavior when permission check fails. Updated the log message to correctly display the repository name when determining push permissions.
Dan7-7-7
reviewed
Nov 4, 2024
Co-authored-by: Richard North <[email protected]>
rnorth
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
BREAKING CHANGE
--no-forkflag in favour of--forkto force forking.Context
The all-or-nothing approach of Turbolift around the clone policy (either forking or branching) is causing a lot of friction and requires the user to think about it.
ghgoes around the problem by cloning normally but checking at push time whether the user has write permission on the target repository and prompt the user what to do.We use a similar mechanism to decide at clone time what the clone policy should be, branching or forking.
The user still has the option to force the forking if they desire.
Change content
Related to
Fixes #146.