Llama+TraderLlama Fix & ExprSpawnerType #7951
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since Bukkit's EntityType has a value for both
LLAMA
andTRADER_LLAMA
by having both of these types being handled/combined in the same EntityData class, lead to some unsavory issues (linked issue).Solution
Updates
LlamaData
,#init, #IsSuperOf, #match
and removes the checks for theTraderLlama.class
Note: I did update
ExprSpawnerType
because the linked issue mentioned the spawner specifically, so I was at that class first.Updates to current code+doc conventions, and adds
DELETE
changemodeTesting Completed
7951-llama and trader llama.sk
Supporting Information
N/A
Completes: #5439
Related: none