Skip to content

Llama+TraderLlama Fix & ExprSpawnerType #7951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: dev/feature
Choose a base branch
from

Conversation

Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Jun 15, 2025

Problem

Since Bukkit's EntityType has a value for both LLAMA and TRADER_LLAMA by having both of these types being handled/combined in the same EntityData class, lead to some unsavory issues (linked issue).

Solution

Updates LlamaData, #init, #IsSuperOf, #match and removes the checks for the TraderLlama.class

Note: I did update ExprSpawnerType because the linked issue mentioned the spawner specifically, so I was at that class first.
Updates to current code+doc conventions, and adds DELETE changemode

Testing Completed

7951-llama and trader llama.sk

Supporting Information

N/A


Completes: #5439
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner June 15, 2025 16:17
@Absolutionism Absolutionism requested review from cheeezburga and TheMug06 and removed request for a team June 15, 2025 16:17
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jun 15, 2025
@Absolutionism Absolutionism added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jun 15, 2025
@sovdeeth sovdeeth moved this to In Review in 2.12 Release Jun 15, 2025
@sovdeeth sovdeeth linked an issue Jun 15, 2025 that may be closed by this pull request
1 task
@Absolutionism Absolutionism changed the title Llama+TraderLlama Fix Llama+TraderLlama Fix &ExprSpawnerType Jun 15, 2025
@Absolutionism Absolutionism changed the title Llama+TraderLlama Fix &ExprSpawnerType Llama+TraderLlama Fix & ExprSpawnerType Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. needs reviews A PR that needs additional reviews
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Llama spawner bug
2 participants