Fix and enhance EffOpenInventory #7508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ayham Al Ali <[email protected]>
…ript into fix/open-inventory
Co-authored-by: Patrick Miller <[email protected]>
Co-authored-by: sovdee <[email protected]>
Moderocky
reviewed
Jan 22, 2025
Comment on lines
+274
to
+279
| } catch (NullPointerException | IllegalArgumentException e) { | ||
| // Spigot forgot to label some InventoryType's as non creatable in some versions < 1.19.4 | ||
| // So this throws NullPointerException aswell ontop of the IllegalArgumentException. | ||
| // See https://hub.spigotmc.org/jira/browse/SPIGOT-7301 | ||
| Skript.error("You can't open a '" + Classes.toString(type) + "' inventory to players. It's not creatable."); | ||
| } |
There was a problem hiding this comment.
I don't think we support less than 1.19.4 anymore so it might be okay to remove this.
|
It looks mostly fine I think. |
Co-authored-by: Moderocky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation #5531
See split commit Modify EffOpenInventory for easy reviewing to allow for easier reviewing of what was changed in EffOpenInventory before rename to EffSecOpenInventory.